Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termbox is no longer maintained. tcell is a recommended replacement #302

Closed
doronbehar opened this issue Mar 8, 2020 · 5 comments · Fixed by #439
Closed

Termbox is no longer maintained. tcell is a recommended replacement #302

doronbehar opened this issue Mar 8, 2020 · 5 comments · Fixed by #439

Comments

@doronbehar
Copy link
Contributor

Hello @gokcehan . It has come to my knowledge that the go library termbox is no longer maintained, see nsf/termbox-go@ed2200f . After encountering nsf/termbox-go#215 , I fixed the issue in nsf/termbox-go#216 and there the author has stated that https://github.com/gdamore/tcell is a recommended replacement.

I'm currently using my own fork of Lf with my own version of termbox that includes that patch. Im using tmux and I experience no issues. My fork of Lf is available here: https://github.com/doronbehar/lf/tree/doronbehar-termbox .

Would you be willing to consider switching to my fork of termbox until a replacement for it will be written? I can send a PR straight from https://github.com/doronbehar/lf/tree/doronbehar-termbox .

@gokcehan
Copy link
Owner

@doronbehar It is unfortunate termbox is not maintained anymore. I tried tcell at one point which also have a termbox compatibility layer but I remember some of the things were not working so I gave up without looking further into it. In the long term, we should switch to tcell, ideally using its own api. Meanwhile, it makes sense to maintain our own fork of termbox. If you're willing to maintain a termbox fork for lf, feel free to send a PR to change it. Thanks in advance.

@doronbehar
Copy link
Contributor Author

If you're willing to maintain a termbox fork for lf, feel free to send a PR to change it.

I wouldn't mind. It's just that I don't want that fork to be considered a permanent replacement. Not to mention security issues which I wouldn't dare take responsibility for. Please @gokcehan take this fork as a mere UX experience improvement for tmux users of Lf (nsf/termbox-go#215).

@gokcehan
Copy link
Owner

@doronbehar I don't think there will be an issue, but if you're worried or don't want any responsibility, I can change lf to use gokcehan/termbox-go and you can send your tmux patch to that fork instead.

@doronbehar
Copy link
Contributor Author

Well maybe it's not that worth your trouble. I'm sure you'll @quote me if needed for any issues related to termbox.

@flw-cn
Copy link

flw-cn commented Jul 10, 2020

Support this idea. According to my research, issue #139 is also due to a flaw in termbox-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants