Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Blob#is_symlink #58

Open
dometto opened this issue Jan 13, 2023 · 3 comments
Open

Rename Blob#is_symlink #58

dometto opened this issue Jan 13, 2023 · 3 comments
Labels
enhancement

Comments

@dometto
Copy link
Member

dometto commented Jan 13, 2023

The RJGit version is called #is_symlink?, which is more idiomatic. This should be added to the adapter specs, too.
@dometto
Copy link
Member Author

dometto commented Jan 14, 2023

Sorry, this was based on a confusion: the methods in both adapters have the same name. But we could make it more idiomatic by renaming to #is_symlink?, and add it to the adapter specs.

@bartkamphorst
Copy link
Member

Should we introduce it as an alias?

@dometto
Copy link
Member Author

dometto commented Jan 14, 2023

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dometto @bartkamphorst