Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong commit message when releasing #947

Open
liry opened this issue Aug 10, 2020 · 1 comment
Open

Wrong commit message when releasing #947

liry opened this issue Aug 10, 2020 · 1 comment

Comments

@liry
Copy link
Contributor

liry commented Aug 10, 2020

Commit 4ddfc56 should have name like "[maven-release-plugin] prepare release gooddata-java-parent-3.1.0+api3", but name of previous commit was used by release plugin %)

Used command: ./release.sh -v 3.1.0

release.sh does:

git commit -a -m "bump version"
mvn --batch-mode release:prepare -DreleaseVersion=${FULL_VERSION} -DdevelopmentVersion=${DEV_VERSION}
@liry
Copy link
Contributor Author

liry commented Nov 10, 2020

  • When mvn release:prepare executed with -DdryRun, it printed correct commit msg:
    [INFO] Full run would be commit 3 files with message: '[maven-release-plugin] prepare release gooddata-java-parent-3.3.0+api3'
    
  • When these git commit and mvn release:prepare executed manually from cmd line, commit msg is also correct:
    4f4452b7 (HEAD -> master) [maven-release-plugin] prepare for next development iteration
    b0550438 (tag: gooddata-java-parent-3.3.0+api3) [maven-release-plugin] prepare release gooddata-java-parent-3.3.0+api3
    ff6768ca bump version
    
  • When mvn release:perform and git push is commented out, commit messages are also ok %)
    a6831486 (HEAD -> liry) [maven-release-plugin] prepare for next development iteration
    2050f95c (tag: gooddata-java-parent-3.3.00+api3) [maven-release-plugin] prepare release gooddata-java-parent-3.3.00+api3
    9736925a bump version
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant