Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about action_tokens usage in _assemble_input_token_sequence #16

Open
oym1994 opened this issue May 13, 2023 · 1 comment
Open

Comments

@oym1994
Copy link

oym1994 commented May 13, 2023

Hi, thanks for your great job!
I have read all the code and found that in the function transformer_network::_assemble_input_token_sequence, action_tokens are used to be a kind of input, but the values all are set to be zero(**action_tokens = tf.zeros_like(action_tokens) **).
My question is that why not use the data here? Have you done any experiment proving that it works bad?
Thanks for your attention and keep waiting for your kind response!

`
def _assemble_input_token_sequence(self, context_image_tokens, action_tokens, batch_size):

action_tokens = tf.one_hot(action_tokens, self._vocab_size)

action_tokens = self._action_token_emb(action_tokens)

action_tokens = tf.zeros_like(action_tokens) 

action_tokens = tf.expand_dims(action_tokens, axis=-2)

input_token_sequence = tf.concat([context_image_tokens, action_tokens],  axis=2)

input_token_sequence = tf.reshape(  input_token_sequence, [batch_size, -1, self._token_embedding_size])

return input_token_sequence

`

@seann999
Copy link

I have the same question.
I was wondering how actions are specifically input into the model since the paper lacks that detail and I was looking into this repository.
And what is b/260260205 and b/254902773 referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants