From a4e62c41b52bf37ed0143ed5d71534c3d264e9de Mon Sep 17 00:00:00 2001
From: Santosh Pingle <spingle@google.com>
Date: Mon, 11 Nov 2024 15:06:58 +0530
Subject: [PATCH 1/4] cancel api to cancel the sync job.

---
 .../android/fhir/demo/PeriodicSyncFragment.kt |  26 ++
 .../fhir/demo/PeriodicSyncViewModel.kt        |  35 ++-
 .../google/android/fhir/demo/SyncFragment.kt  |  31 ++-
 .../fhir/demo/SyncFragmentViewModel.kt        |  38 ++-
 demo/src/main/res/layout/periodic_sync.xml    |  38 +++
 demo/src/main/res/layout/sync.xml             |  18 ++
 .../android/fhir/sync/SyncInstrumentedTest.kt | 229 +++++++++++-------
 .../java/com/google/android/fhir/sync/Sync.kt | 119 +++++----
 8 files changed, 365 insertions(+), 169 deletions(-)

diff --git a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncFragment.kt b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncFragment.kt
index 4fc6d3c830..74aee0db92 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncFragment.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncFragment.kt
@@ -21,6 +21,7 @@ import android.view.LayoutInflater
 import android.view.MenuItem
 import android.view.View
 import android.view.ViewGroup
+import android.widget.Button
 import android.widget.ProgressBar
 import android.widget.TextView
 import androidx.appcompat.app.AppCompatActivity
@@ -48,6 +49,7 @@ class PeriodicSyncFragment : Fragment() {
     setUpActionBar()
     setHasOptionsMenu(true)
     refreshPeriodicSynUi()
+    setUpSyncButtons(view)
   }
 
   override fun onOptionsItemSelected(item: MenuItem): Boolean {
@@ -67,6 +69,30 @@ class PeriodicSyncFragment : Fragment() {
     }
   }
 
+  private fun setUpSyncButtons(view: View) {
+    val syncNowButton = view.findViewById<Button>(R.id.sync_now_button)
+    val cancelSyncButton = view.findViewById<Button>(R.id.cancel_sync_button)
+    syncNowButton.apply {
+      setOnClickListener {
+        periodicSyncViewModel.collectPeriodicSyncJobStatus()
+        toggleButtonVisibility(hiddenButton = syncNowButton, visibleButton = cancelSyncButton)
+        visibility = View.GONE
+      }
+    }
+    cancelSyncButton.apply {
+      setOnClickListener {
+        periodicSyncViewModel.cancelPeriodicSyncJob()
+        toggleButtonVisibility(hiddenButton = cancelSyncButton, visibleButton = syncNowButton)
+        visibility = View.GONE
+      }
+    }
+  }
+
+  private fun toggleButtonVisibility(hiddenButton: View, visibleButton: View) {
+    hiddenButton.visibility = View.GONE
+    visibleButton.visibility = View.VISIBLE
+  }
+
   private fun refreshPeriodicSynUi() {
     viewLifecycleOwner.lifecycleScope.launch {
       viewLifecycleOwner.lifecycle.repeatOnLifecycle(Lifecycle.State.STARTED) {
diff --git a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
index f5a230bd10..6406056499 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
@@ -30,37 +30,46 @@ import com.google.android.fhir.sync.PeriodicSyncJobStatus
 import com.google.android.fhir.sync.RepeatInterval
 import com.google.android.fhir.sync.Sync
 import com.google.android.fhir.sync.SyncJobStatus
+import java.util.*
 import java.util.concurrent.TimeUnit
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.SharedFlow
 import kotlinx.coroutines.flow.SharingStarted
 import kotlinx.coroutines.flow.StateFlow
+import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.shareIn
 import kotlinx.coroutines.launch
+import timber.log.Timber
 
 class PeriodicSyncViewModel(application: Application) : AndroidViewModel(application) {
 
-  val pollPeriodicSyncJobStatus: SharedFlow<PeriodicSyncJobStatus> =
+  private val _uiStateFlow = MutableStateFlow(PeriodicSyncUiState())
+  val uiStateFlow: StateFlow<PeriodicSyncUiState> = _uiStateFlow
+  private var periodicSyncJobId: UUID? = null
+  private val pollPeriodicSyncJobStatus: SharedFlow<PeriodicSyncJobStatus> by lazy {
     Sync.periodicSync<DemoFhirSyncWorker>(
-        application.applicationContext,
+        context = application.applicationContext,
         periodicSyncConfiguration =
           PeriodicSyncConfiguration(
             syncConstraints = Constraints.Builder().build(),
             repeat = RepeatInterval(interval = 15, timeUnit = TimeUnit.MINUTES),
           ),
       )
-      .shareIn(viewModelScope, SharingStarted.Eagerly, 10)
-
-  private val _uiStateFlow = MutableStateFlow(PeriodicSyncUiState())
-  val uiStateFlow: StateFlow<PeriodicSyncUiState> = _uiStateFlow
-
-  init {
-    collectPeriodicSyncJobStatus()
+      .let { (statusFlow, uuid) ->
+        periodicSyncJobId = uuid
+        statusFlow.map { status ->
+          status // Return status directly, preserving the original signature
+        }
+      }
+      .shareIn(viewModelScope, SharingStarted.Eagerly, replay = 10)
   }
 
-  private fun collectPeriodicSyncJobStatus() {
+  fun collectPeriodicSyncJobStatus() {
     viewModelScope.launch {
       pollPeriodicSyncJobStatus.collect { periodicSyncJobStatus ->
+        Timber.d(
+          "currentSyncJobStatus: ${periodicSyncJobStatus.currentSyncJobStatus}  lastSyncJobStatus ${periodicSyncJobStatus.lastSyncJobStatus}",
+        )
         val lastSyncStatus = getLastSyncStatus(periodicSyncJobStatus.lastSyncJobStatus)
         val lastSyncTime = getLastSyncTime(periodicSyncJobStatus.lastSyncJobStatus)
         val currentSyncStatus =
@@ -83,6 +92,12 @@ class PeriodicSyncViewModel(application: Application) : AndroidViewModel(applica
     }
   }
 
+  fun cancelPeriodicSyncJob() {
+    periodicSyncJobId?.let {
+      Sync.cancelWorkById(getApplication<FhirApplication>().applicationContext, it)
+    }
+  }
+
   private fun getLastSyncStatus(lastSyncJobStatus: LastSyncJobStatus?): String? {
     return when (lastSyncJobStatus) {
       is LastSyncJobStatus.Succeeded ->
diff --git a/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt b/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt
index 4aaafe8950..53eac823c8 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt
@@ -30,6 +30,7 @@ import androidx.fragment.app.viewModels
 import androidx.navigation.fragment.NavHostFragment
 import com.google.android.fhir.demo.extensions.launchAndRepeatStarted
 import com.google.android.fhir.sync.CurrentSyncJobStatus
+import timber.log.Timber
 
 class SyncFragment : Fragment() {
   private val syncFragmentViewModel: SyncFragmentViewModel by viewModels()
@@ -49,9 +50,12 @@ class SyncFragment : Fragment() {
     view.findViewById<Button>(R.id.sync_now_button).setOnClickListener {
       syncFragmentViewModel.triggerOneTimeSync()
     }
+    view.findViewById<Button>(R.id.cancel_sync_button).setOnClickListener {
+      syncFragmentViewModel.cancelOneTimeSyncWork()
+    }
     observeLastSyncTime()
     launchAndRepeatStarted(
-      { syncFragmentViewModel.pollState.collect(::currentSyncJobStatus) },
+      { syncFragmentViewModel.pollState.collect(::updateSyncJobStatus) },
     )
   }
 
@@ -72,25 +76,42 @@ class SyncFragment : Fragment() {
     }
   }
 
-  private fun currentSyncJobStatus(currentSyncJobStatus: CurrentSyncJobStatus) {
-    requireView().findViewById<TextView>(R.id.current_status).text =
+  private fun updateSyncJobStatus(currentSyncJobStatus: CurrentSyncJobStatus) {
+    Timber.d("currentSyncJobStatus: $currentSyncJobStatus")
+    // Update status text
+    val statusTextView = requireView().findViewById<TextView>(R.id.current_status)
+    statusTextView.text =
       getString(R.string.current_status, currentSyncJobStatus::class.java.simpleName)
 
-    // Update progress indicator visibility and handle status-specific actions
+    // Get views once to avoid repeated lookups
     val syncIndicator = requireView().findViewById<ProgressBar>(R.id.sync_indicator)
+    val syncNowButton = requireView().findViewById<Button>(R.id.sync_now_button)
+    val cancelSyncButton = requireView().findViewById<Button>(R.id.cancel_sync_button)
+
+    // Update view states based on sync status
     when (currentSyncJobStatus) {
       is CurrentSyncJobStatus.Running -> {
         syncIndicator.visibility = View.VISIBLE
+        syncNowButton.visibility = View.GONE
+        cancelSyncButton.visibility = View.VISIBLE
       }
       is CurrentSyncJobStatus.Succeeded -> {
         syncIndicator.visibility = View.GONE
         syncFragmentViewModel.updateLastSyncTimestamp(currentSyncJobStatus.timestamp)
+        syncNowButton.visibility = View.VISIBLE
+        cancelSyncButton.visibility = View.GONE
       }
       is CurrentSyncJobStatus.Failed,
+      is CurrentSyncJobStatus.Cancelled, -> {
+        syncIndicator.visibility = View.GONE
+        syncNowButton.visibility = View.VISIBLE
+        cancelSyncButton.visibility = View.GONE
+      }
       is CurrentSyncJobStatus.Enqueued,
-      is CurrentSyncJobStatus.Cancelled,
       is CurrentSyncJobStatus.Blocked, -> {
         syncIndicator.visibility = View.GONE
+        syncNowButton.visibility = View.GONE
+        cancelSyncButton.visibility = View.VISIBLE
       }
     }
   }
diff --git a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
index b1f4063b97..584be5cb3d 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
@@ -27,6 +27,7 @@ import com.google.android.fhir.sync.CurrentSyncJobStatus
 import com.google.android.fhir.sync.Sync
 import java.time.OffsetDateTime
 import java.time.format.DateTimeFormatter
+import java.util.*
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.channels.BufferOverflow
 import kotlinx.coroutines.flow.MutableSharedFlow
@@ -40,6 +41,7 @@ import kotlinx.coroutines.launch
 /** View model for [MainActivity]. */
 @OptIn(ExperimentalCoroutinesApi::class)
 class SyncFragmentViewModel(application: Application) : AndroidViewModel(application) {
+  private var oneTimeSyncUuid: UUID? = null
   private val _lastSyncTimestampLiveData = MutableLiveData<String>()
   val lastSyncTimestampLiveData: LiveData<String>
     get() = _lastSyncTimestampLiveData
@@ -50,18 +52,50 @@ class SyncFragmentViewModel(application: Application) : AndroidViewModel(applica
       onBufferOverflow = BufferOverflow.DROP_OLDEST,
     )
 
+  //  val pollState: SharedFlow<CurrentSyncJobStatus> =
+  //    _oneTimeSyncTrigger
+  //      .flatMapLatest {
+  //        Sync.oneTimeSync<DemoFhirSyncWorker>(context = application.applicationContext)
+  //      }
+  //      .map { it }
+  //      .shareIn(viewModelScope, SharingStarted.Eagerly, 0)
+
   val pollState: SharedFlow<CurrentSyncJobStatus> =
     _oneTimeSyncTrigger
       .flatMapLatest {
-        Sync.oneTimeSync<DemoFhirSyncWorker>(context = application.applicationContext)
+        val (statusFlow, uuid) =
+          Sync.oneTimeSync<DemoFhirSyncWorker>(
+            context = application.applicationContext,
+          )
+        oneTimeSyncUuid = uuid
+        statusFlow
       }
       .map { it }
-      .shareIn(viewModelScope, SharingStarted.Eagerly, 0)
+      .shareIn(viewModelScope, SharingStarted.Eagerly, replay = 0)
+
+  //  val pollState: SharedFlow<Pair<UUID, CurrentSyncJobStatus>> =
+  //    _oneTimeSyncTrigger
+  //      .flatMapLatest {
+  //        // Destructure the Pair to get both the Flow and UUID
+  //        val (statusFlow, uuid) = Sync.oneTimeSync<DemoFhirSyncWorker>(
+  //          context = application.applicationContext
+  //        )
+  //
+  //        // Map each status emission to include the UUID as a Pair
+  //        statusFlow.map { status ->
+  //          Pair(uuid, status) // Create Pair with UUID and status
+  //        }
+  //      }
+  //      .shareIn(viewModelScope, SharingStarted.Eagerly, replay = 0)
 
   fun triggerOneTimeSync() {
     viewModelScope.launch { _oneTimeSyncTrigger.emit(true) }
   }
 
+  fun cancelOneTimeSyncWork() {
+    oneTimeSyncUuid?.let { Sync.cancelWorkById(getApplication(), it) }
+  }
+
   /** Emits last sync time. */
   fun updateLastSyncTimestamp(lastSync: OffsetDateTime? = null) {
     val formatter =
diff --git a/demo/src/main/res/layout/periodic_sync.xml b/demo/src/main/res/layout/periodic_sync.xml
index 3a3b835342..911f40cfa9 100644
--- a/demo/src/main/res/layout/periodic_sync.xml
+++ b/demo/src/main/res/layout/periodic_sync.xml
@@ -87,4 +87,42 @@
         android:layout_marginTop="8dp"
     />
 
+  <!-- Sync Now Button -->
+  <Button
+        android:id="@+id/sync_now_button"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintTop_toBottomOf="@id/progress_percentage_label"
+        app:layout_constraintBottom_toBottomOf="parent"
+        android:layout_marginTop="16dp"
+        android:layout_marginBottom="64dp"
+        android:paddingLeft="24dp"
+        android:paddingRight="24dp"
+        android:text="Sync Now"
+        android:backgroundTint="?attr/colorPrimary"
+        android:textColor="?attr/colorOnPrimary"
+        app:layout_goneMarginTop="16dp"
+    />
+
+  <Button
+        android:id="@+id/cancel_sync_button"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintTop_toBottomOf="@id/progress_percentage_label"
+        app:layout_constraintBottom_toBottomOf="parent"
+        android:layout_marginTop="16dp"
+        android:layout_marginBottom="64dp"
+        android:paddingLeft="24dp"
+        android:paddingRight="24dp"
+        android:text="Cancel Sync"
+        android:backgroundTint="?attr/colorPrimary"
+        android:textColor="?attr/colorOnPrimary"
+        android:visibility="gone"
+        app:layout_goneMarginTop="16dp"
+    />
+
 </androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/demo/src/main/res/layout/sync.xml b/demo/src/main/res/layout/sync.xml
index c7687e4f84..0bed92c94d 100644
--- a/demo/src/main/res/layout/sync.xml
+++ b/demo/src/main/res/layout/sync.xml
@@ -79,4 +79,22 @@
         android:textColor="?attr/colorOnPrimary"
     />
 
+  <Button
+        android:id="@+id/cancel_sync_button"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintTop_toBottomOf="@id/sync_now_button"
+        app:layout_constraintBottom_toBottomOf="parent"
+        android:layout_marginTop="16dp"
+        android:layout_marginBottom="64dp"
+        android:paddingLeft="24dp"
+        android:paddingRight="24dp"
+        android:text="Cancel Sync"
+        android:backgroundTint="?attr/colorPrimary"
+        android:textColor="?attr/colorOnPrimary"
+        android:visibility="gone"
+    />
+
 </androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt b/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt
index 5bd8117f1f..382dbd1608 100644
--- a/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt
+++ b/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt
@@ -86,12 +86,13 @@ class SyncInstrumentedTest {
     WorkManagerTestInitHelper.initializeTestWorkManager(context)
     val workManager = WorkManager.getInstance(context)
     runBlocking {
-      Sync.oneTimeSync<TestSyncWorker>(context = context)
-        .transformWhile {
-          emit(it is CurrentSyncJobStatus.Succeeded)
-          it !is CurrentSyncJobStatus.Succeeded
+      val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+      statusFlow
+        .transformWhile { status ->
+          emit(status is CurrentSyncJobStatus.Succeeded)
+          status !is CurrentSyncJobStatus.Succeeded
         }
-        .shareIn(this, SharingStarted.Eagerly, 5)
+        .shareIn(this, SharingStarted.Eagerly, replay = 5)
     }
 
     assertThat(workManager.getWorkInfosByTag(TestSyncWorker::class.java.name).get().first().state)
@@ -103,13 +104,20 @@ class SyncInstrumentedTest {
     WorkManagerTestInitHelper.initializeTestWorkManager(context)
     val states = mutableListOf<CurrentSyncJobStatus>()
     runBlocking {
-      Sync.oneTimeSync<TestSyncWorker>(context = context)
-        .transformWhile {
-          states.add(it)
-          emit(it is CurrentSyncJobStatus.Succeeded)
-          it !is CurrentSyncJobStatus.Succeeded
-        }
-        .shareIn(this, SharingStarted.Eagerly, 5)
+      val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+      launch {
+        statusFlow
+          .transformWhile { status ->
+            states.add(status)
+            emit(status is CurrentSyncJobStatus.Succeeded)
+            status !is CurrentSyncJobStatus.Succeeded
+          }
+          .collect { isSuccess ->
+            if (isSuccess) {
+              // Flow has completed successfully
+            }
+          }
+      }
     }
     assertThat(states.first()).isInstanceOf(CurrentSyncJobStatus.Running::class.java)
     assertThat(states.last()).isInstanceOf(CurrentSyncJobStatus.Succeeded::class.java)
@@ -122,20 +130,24 @@ class SyncInstrumentedTest {
       val states = mutableListOf<CurrentSyncJobStatus>()
       val nextExecutionStates = mutableListOf<CurrentSyncJobStatus>()
 
+      // First one-time sync
       launch {
-          Sync.oneTimeSync<TestSyncWorker>(context = context).collect {
-            states.add(it)
-            if (it is CurrentSyncJobStatus.Succeeded) {
+          val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+          statusFlow.collect { status ->
+            states.add(status)
+            if (status is CurrentSyncJobStatus.Succeeded) {
               cancel()
             }
           }
         }
         .join()
 
+      // Second one-time sync
       launch {
-          Sync.oneTimeSync<TestSyncWorker>(context = context).collect {
-            nextExecutionStates.add(it)
-            if (it is CurrentSyncJobStatus.Succeeded) {
+          val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+          statusFlow.collect { status ->
+            nextExecutionStates.add(status)
+            if (status is CurrentSyncJobStatus.Succeeded) {
               cancel()
             }
           }
@@ -151,25 +163,38 @@ class SyncInstrumentedTest {
   fun oneTime_worker_failedSyncState() {
     WorkManagerTestInitHelper.initializeTestWorkManager(context)
     val states = mutableListOf<CurrentSyncJobStatus>()
+
     runBlocking {
-      Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
+      val (statusFlow, _) =
+        Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
           context = context,
-          RetryConfiguration(
-            BackoffCriteria(
-              BackoffPolicy.LINEAR,
-              30,
-              TimeUnit.SECONDS,
+          retryConfiguration =
+            RetryConfiguration(
+              backoffCriteria =
+                BackoffCriteria(
+                  BackoffPolicy.LINEAR,
+                  30,
+                  TimeUnit.SECONDS,
+                ),
+              maxRetries = 0,
             ),
-            0,
-          ),
         )
-        .transformWhile {
-          states.add(it)
-          emit(it is CurrentSyncJobStatus.Failed)
-          it !is CurrentSyncJobStatus.Failed
-        }
-        .shareIn(this, SharingStarted.Eagerly, 5)
+
+      launch {
+        statusFlow
+          .transformWhile { status ->
+            states.add(status)
+            emit(status is CurrentSyncJobStatus.Failed)
+            status !is CurrentSyncJobStatus.Failed
+          }
+          .collect { isFailed ->
+            if (isFailed) {
+              // Flow has completed with a failure
+            }
+          }
+      }
     }
+
     assertThat(states.first()).isInstanceOf(CurrentSyncJobStatus.Running::class.java)
     assertThat(states.last()).isInstanceOf(CurrentSyncJobStatus.Failed::class.java)
   }
@@ -182,44 +207,52 @@ class SyncInstrumentedTest {
       val nextExecutionStates = mutableListOf<CurrentSyncJobStatus>()
 
       launch {
-          Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
+          val (statusFlow, _) =
+            Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
               context = context,
-              RetryConfiguration(
-                BackoffCriteria(
-                  BackoffPolicy.LINEAR,
-                  30,
-                  TimeUnit.SECONDS,
+              retryConfiguration =
+                RetryConfiguration(
+                  backoffCriteria =
+                    BackoffCriteria(
+                      BackoffPolicy.LINEAR,
+                      30,
+                      TimeUnit.SECONDS,
+                    ),
+                  maxRetries = 0,
                 ),
-                0,
-              ),
             )
-            .collect {
-              states.add(it)
-              if (it is CurrentSyncJobStatus.Failed) {
-                cancel()
-              }
+
+          statusFlow.collect { status ->
+            states.add(status)
+            if (status is CurrentSyncJobStatus.Failed) {
+              cancel()
             }
+          }
         }
         .join()
 
       launch {
-          Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
+          val (nextStatusFlow, _) =
+            Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
               context = context,
-              RetryConfiguration(
-                BackoffCriteria(
-                  BackoffPolicy.LINEAR,
-                  30,
-                  TimeUnit.SECONDS,
+              retryConfiguration =
+                RetryConfiguration(
+                  backoffCriteria =
+                    BackoffCriteria(
+                      BackoffPolicy.LINEAR,
+                      30,
+                      TimeUnit.SECONDS,
+                    ),
+                  maxRetries = 0,
                 ),
-                0,
-              ),
             )
-            .collect {
-              nextExecutionStates.add(it)
-              if (it is CurrentSyncJobStatus.Failed) {
-                cancel()
-              }
+
+          nextStatusFlow.collect { status ->
+            nextExecutionStates.add(status)
+            if (status is CurrentSyncJobStatus.Failed) {
+              cancel()
             }
+          }
         }
         .join()
 
@@ -234,7 +267,8 @@ class SyncInstrumentedTest {
     val states = mutableListOf<PeriodicSyncJobStatus>()
     // run and wait for periodic worker to finish
     runBlocking {
-      Sync.periodicSync<TestSyncWorker>(
+      val (flow, _) =
+        Sync.periodicSync<TestSyncWorker>(
           context = context,
           periodicSyncConfiguration =
             PeriodicSyncConfiguration(
@@ -242,6 +276,7 @@ class SyncInstrumentedTest {
               repeat = RepeatInterval(interval = 15, timeUnit = TimeUnit.MINUTES),
             ),
         )
+      flow
         .transformWhile {
           states.add(it)
           emit(it)
@@ -263,9 +298,10 @@ class SyncInstrumentedTest {
   fun periodic_worker_failedPeriodicSyncState() {
     WorkManagerTestInitHelper.initializeTestWorkManager(context)
     val states = mutableListOf<PeriodicSyncJobStatus>()
-    // run and wait for periodic worker to finish
+
     runBlocking {
-      Sync.periodicSync<TestSyncWorkerForDownloadFailing>(
+      val (statusFlow, _) =
+        Sync.periodicSync<TestSyncWorkerForDownloadFailing>(
           context = context,
           periodicSyncConfiguration =
             PeriodicSyncConfiguration(
@@ -273,12 +309,18 @@ class SyncInstrumentedTest {
               repeat = RepeatInterval(interval = 15, timeUnit = TimeUnit.MINUTES),
             ),
         )
-        .transformWhile {
-          states.add(it)
-          emit(it)
-          it.currentSyncJobStatus !is CurrentSyncJobStatus.Enqueued
-        }
-        .shareIn(this, SharingStarted.Eagerly, 5)
+
+      launch {
+        statusFlow
+          .transformWhile { status ->
+            states.add(status)
+            emit(status)
+            status.currentSyncJobStatus !is CurrentSyncJobStatus.Enqueued
+          }
+          .collect { status ->
+            // Flow has emitted a value
+          }
+      }
     }
 
     assertThat(states.first().currentSyncJobStatus)
@@ -293,9 +335,11 @@ class SyncInstrumentedTest {
   fun periodic_worker_still_queued_to_run_after_oneTime_worker_started() {
     WorkManagerTestInitHelper.initializeTestWorkManager(context)
     val workManager = WorkManager.getInstance(context)
-    // run and wait for periodic worker to finish
+
+    // Run and wait for periodic worker to finish
     runBlocking {
-      Sync.periodicSync<TestSyncWorker>(
+      val (statusFlow, periodicWorkerId) =
+        Sync.periodicSync<TestSyncWorker>(
           context = context,
           periodicSyncConfiguration =
             PeriodicSyncConfiguration(
@@ -303,36 +347,47 @@ class SyncInstrumentedTest {
               repeat = RepeatInterval(interval = 15, timeUnit = TimeUnit.MINUTES),
             ),
         )
-        .transformWhile {
-          emit(it)
-          it.currentSyncJobStatus !is CurrentSyncJobStatus.Enqueued
-        }
-        .shareIn(this, SharingStarted.Eagerly, 5)
+
+      launch {
+        statusFlow
+          .transformWhile { status ->
+            emit(status)
+            status.currentSyncJobStatus !is CurrentSyncJobStatus.Enqueued
+          }
+          .collect { status -> }
+      }
     }
 
-    // Verify the periodic worker completed the run, and is queued to run again
-    val periodicWorkerId =
-      workManager.getWorkInfosByTag(TestSyncWorker::class.java.name).get().first().id
-    assertThat(workManager.getWorkInfoById(periodicWorkerId).get().state)
-      .isEqualTo(WorkInfo.State.ENQUEUED)
+    // Verify the periodic worker completed the run and is queued to run again
+    val periodicWorkerInfo =
+      workManager
+        .getWorkInfoById(
+          workManager.getWorkInfosByTag(TestSyncWorker::class.java.name).get().first().id,
+        )
+        .get()
+    assertThat(periodicWorkerInfo.state).isEqualTo(WorkInfo.State.ENQUEUED)
 
-    // Start and complete a oneTime job, and verify it does not remove the periodic worker
+    // Start and complete a one-time job, and verify it does not remove the periodic worker
     runBlocking {
-      Sync.oneTimeSync<TestSyncWorker>(context = context)
-        .transformWhile {
-          emit(it)
-          it !is CurrentSyncJobStatus.Succeeded
+      val (oneTimeStatusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+
+      oneTimeStatusFlow
+        .transformWhile { status ->
+          emit(status)
+          status !is CurrentSyncJobStatus.Succeeded
         }
-        .shareIn(this, SharingStarted.Eagerly, 5)
+        .collect { status -> }
     }
+
     assertThat(workManager.getWorkInfosByTag(TestSyncWorker::class.java.name).get().size)
       .isEqualTo(2)
 
     // Move forward to the next epoch to trigger the periodic sync
     val testDriver = WorkManagerTestInitHelper.getTestDriver(context)
-    testDriver?.setPeriodDelayMet(periodicWorkerId)
+    testDriver?.setPeriodDelayMet(periodicWorkerInfo.id)
 
-    assertThat(workManager.getWorkInfoById(periodicWorkerId).get().state)
+    // Confirm the periodic worker is running after advancing the period
+    assertThat(workManager.getWorkInfoById(periodicWorkerInfo.id).get().state)
       .isEqualTo(WorkInfo.State.RUNNING)
   }
 }
diff --git a/engine/src/main/java/com/google/android/fhir/sync/Sync.kt b/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
index e4a3615605..fc8396a4ae 100644
--- a/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
+++ b/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
@@ -42,12 +42,14 @@ import com.google.android.fhir.sync.CurrentSyncJobStatus.Succeeded
 import com.google.gson.Gson
 import com.google.gson.GsonBuilder
 import java.time.OffsetDateTime
+import java.util.*
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.asFlow
 import kotlinx.coroutines.flow.combine
 import kotlinx.coroutines.flow.flatMapConcat
 import kotlinx.coroutines.flow.mapNotNull
+import timber.log.Timber
 
 object Sync {
   val gson: Gson =
@@ -67,7 +69,7 @@ object Sync {
   inline fun <reified W : FhirSyncWorker> oneTimeSync(
     context: Context,
     retryConfiguration: RetryConfiguration? = defaultRetryConfiguration,
-  ): Flow<CurrentSyncJobStatus> {
+  ): Pair<Flow<CurrentSyncJobStatus>, UUID> {
     val uniqueWorkName = "${W::class.java.name}-oneTimeSync"
     val flow = getWorkerInfo(context, uniqueWorkName)
     val oneTimeWorkRequest =
@@ -78,7 +80,8 @@ object Sync {
         ExistingWorkPolicy.KEEP,
         oneTimeWorkRequest,
       )
-    return combineSyncStateForOneTimeSync(context, uniqueWorkName, flow)
+    val workId = oneTimeWorkRequest.id
+    return Pair(combineSyncStateForOneTimeSync(context, uniqueWorkName, flow), workId)
   }
 
   /**
@@ -95,7 +98,7 @@ object Sync {
   inline fun <reified W : FhirSyncWorker> periodicSync(
     context: Context,
     periodicSyncConfiguration: PeriodicSyncConfiguration,
-  ): Flow<PeriodicSyncJobStatus> {
+  ): Pair<Flow<PeriodicSyncJobStatus>, UUID> {
     val uniqueWorkName = "${W::class.java.name}-periodicSync"
     val flow = getWorkerInfo(context, uniqueWorkName)
     val periodicWorkRequest =
@@ -106,7 +109,12 @@ object Sync {
         ExistingPeriodicWorkPolicy.KEEP,
         periodicWorkRequest,
       )
-    return combineSyncStateForPeriodicSync(context, uniqueWorkName, flow)
+    val workId = periodicWorkRequest.id
+    return Pair(combineSyncStateForPeriodicSync(context, uniqueWorkName, flow), workId)
+  }
+
+  fun cancelWorkById(context: Context, workId: UUID) {
+    WorkManager.getInstance(context).cancelWorkById(workId)
   }
 
   /**
@@ -160,8 +168,7 @@ object Sync {
       PeriodicSyncJobStatus(
         lastSyncJobStatus = mapSyncJobStatusToResult(syncJobStatusFromDataStore),
         currentSyncJobStatus =
-          createSyncState(
-            WorkRequest.PERIODIC,
+          createSyncStateForPeriodicSync(
             workerInfoSyncJobStatusPairFromWorkManager.first,
             workerInfoSyncJobStatusPairFromWorkManager.second,
             syncJobStatusFromDataStore,
@@ -192,8 +199,7 @@ object Sync {
       workerInfoSyncJobStatusPairFromWorkManager,
       syncJobStatusFromDataStore,
       ->
-      createSyncState(
-        WorkRequest.ONE_TIME,
+      createSyncStateForOneTimeSync(
         workerInfoSyncJobStatusPairFromWorkManager.first,
         workerInfoSyncJobStatusPairFromWorkManager.second,
         syncJobStatusFromDataStore,
@@ -259,40 +265,25 @@ object Sync {
     return FhirEngineProvider.getFhirDataStore(context).readLastSyncTimestamp()
   }
 
-  private fun createSyncState(
-    workRequest: WorkRequest,
+  private fun createSyncStateForOneTimeSync(
     workInfoState: WorkInfo.State,
     syncJobStatusFromWorkManager: SyncJobStatus?,
     syncJobStatusFromDataStore: SyncJobStatus?,
   ): CurrentSyncJobStatus {
-    return when (syncJobStatusFromWorkManager) {
-      is SyncJobStatus.Started,
-      is SyncJobStatus.InProgress, -> Running(syncJobStatusFromWorkManager)
-      null -> {
-        when (workRequest) {
-          WorkRequest.ONE_TIME ->
-            handleNullWorkManagerStatusForOneTimeSync(workInfoState, syncJobStatusFromDataStore)
-          WorkRequest.PERIODIC -> handleNullWorkManagerStatusForPeriodicSync(workInfoState)
+    return when (workInfoState) {
+      WorkInfo.State.ENQUEUED -> {
+        Enqueued
+      }
+      WorkInfo.State.RUNNING -> {
+        return when (syncJobStatusFromWorkManager) {
+          is SyncJobStatus.Started,
+          is SyncJobStatus.InProgress, -> Running(syncJobStatusFromWorkManager)
+          is SyncJobStatus.Succeeded -> Succeeded(syncJobStatusFromWorkManager.timestamp)
+          is SyncJobStatus.Failed -> Failed(syncJobStatusFromWorkManager.timestamp)
+          null -> Running(SyncJobStatus.Started())
         }
       }
-      else -> error("Inconsistent syncJobStatus: $syncJobStatusFromWorkManager.")
-    }
-  }
-
-  /**
-   * Creates terminal states of [CurrentSyncJobStatus] from [syncJobStatusFromDataStore]; and
-   * intermediate states of [CurrentSyncJobStatus] from [WorkInfo.State].
-   *
-   * Note : Only call this API when `syncJobStatusFromWorkManager` is null.
-   */
-  private fun handleNullWorkManagerStatusForOneTimeSync(
-    workInfoState: WorkInfo.State,
-    syncJobStatusFromDataStore: SyncJobStatus?,
-  ): CurrentSyncJobStatus =
-    when (workInfoState) {
-      ENQUEUED -> Enqueued
-      RUNNING -> Running(SyncJobStatus.Started())
-      SUCCEEDED ->
+      WorkInfo.State.SUCCEEDED -> {
         syncJobStatusFromDataStore?.let {
           when (it) {
             is SyncJobStatus.Succeeded -> Succeeded(it.timestamp)
@@ -300,7 +291,8 @@ object Sync {
           }
         }
           ?: error("Inconsistent terminal syncJobStatus.")
-      FAILED ->
+      }
+      WorkInfo.State.FAILED -> {
         syncJobStatusFromDataStore?.let {
           when (it) {
             is SyncJobStatus.Failed -> Failed(it.timestamp)
@@ -308,34 +300,36 @@ object Sync {
           }
         }
           ?: error("Inconsistent terminal syncJobStatus.")
-      CANCELLED -> Cancelled
-      BLOCKED -> CurrentSyncJobStatus.Blocked
+      }
+      WorkInfo.State.CANCELLED -> Cancelled
+      WorkInfo.State.BLOCKED -> CurrentSyncJobStatus.Blocked
     }
+  }
 
-  /**
-   * Only call this API when syncJobStatus From WorkManager is null. Create a [CurrentSyncJobStatus]
-   * from [WorkInfo.State]. (Note: syncJobStatusFromDataStore is updated as lastSynJobStatus, which
-   * is the terminalSyncJobStatus.)
-   */
-  private fun handleNullWorkManagerStatusForPeriodicSync(
+  private fun createSyncStateForPeriodicSync(
     workInfoState: WorkInfo.State,
-  ): CurrentSyncJobStatus =
-    when (workInfoState) {
-      RUNNING -> Running(SyncJobStatus.Started())
-      ENQUEUED -> Enqueued
-      CANCELLED -> Cancelled
-      BLOCKED -> CurrentSyncJobStatus.Blocked
+    syncJobStatusFromWorkManager: SyncJobStatus?,
+    syncJobStatusFromDataStore: SyncJobStatus?,
+  ): CurrentSyncJobStatus {
+    Timber.d(
+      "currentSyncJobStatus : $syncJobStatusFromWorkManager syncJobStatusFromDataStore: $syncJobStatusFromDataStore workInfoState: $workInfoState",
+    )
+    return when (workInfoState) {
+      WorkInfo.State.ENQUEUED -> Enqueued
+      WorkInfo.State.RUNNING -> {
+        return when (syncJobStatusFromWorkManager) {
+          is SyncJobStatus.Started,
+          is SyncJobStatus.InProgress, -> Running(syncJobStatusFromWorkManager)
+          is SyncJobStatus.Succeeded -> Succeeded(syncJobStatusFromWorkManager.timestamp)
+          is SyncJobStatus.Failed -> Failed(syncJobStatusFromWorkManager.timestamp)
+          null -> Running(SyncJobStatus.Started())
+        }
+      }
+      WorkInfo.State.CANCELLED -> Cancelled
+      WorkInfo.State.BLOCKED -> CurrentSyncJobStatus.Blocked
       else -> error("Inconsistent WorkInfo.State in periodic sync : $workInfoState.")
     }
-
-  private fun mapDataStoreSyncJobStatusToCurrentSyncJobStatus(
-    syncJobStatusFromDataStore: SyncJobStatus,
-  ) =
-    when (syncJobStatusFromDataStore) {
-      is SyncJobStatus.Succeeded -> Succeeded(syncJobStatusFromDataStore.timestamp)
-      is SyncJobStatus.Failed -> Failed(syncJobStatusFromDataStore.timestamp)
-      else -> error("Inconsistent syncJobStatus in the dataStore : $syncJobStatusFromDataStore.")
-    }
+  }
 
   /**
    * Maps the [lastSyncJobStatus] to a specific [LastSyncJobStatus] based on the provided status.
@@ -358,9 +352,4 @@ object Sync {
         else -> error("Inconsistent terminal syncJobStatus : $lastSyncJobStatus")
       }
     }
-
-  private enum class WorkRequest {
-    ONE_TIME,
-    PERIODIC,
-  }
 }

From ac116088cfe1c2527e56654d5b8f95777c69a635 Mon Sep 17 00:00:00 2001
From: Santosh Pingle <spingle@google.com>
Date: Mon, 11 Nov 2024 15:22:02 +0530
Subject: [PATCH 2/4] remove  commented code.

---
 .../fhir/demo/SyncFragmentViewModel.kt        | 23 -------------------
 1 file changed, 23 deletions(-)

diff --git a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
index 584be5cb3d..b849a88598 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
@@ -52,14 +52,6 @@ class SyncFragmentViewModel(application: Application) : AndroidViewModel(applica
       onBufferOverflow = BufferOverflow.DROP_OLDEST,
     )
 
-  //  val pollState: SharedFlow<CurrentSyncJobStatus> =
-  //    _oneTimeSyncTrigger
-  //      .flatMapLatest {
-  //        Sync.oneTimeSync<DemoFhirSyncWorker>(context = application.applicationContext)
-  //      }
-  //      .map { it }
-  //      .shareIn(viewModelScope, SharingStarted.Eagerly, 0)
-
   val pollState: SharedFlow<CurrentSyncJobStatus> =
     _oneTimeSyncTrigger
       .flatMapLatest {
@@ -73,21 +65,6 @@ class SyncFragmentViewModel(application: Application) : AndroidViewModel(applica
       .map { it }
       .shareIn(viewModelScope, SharingStarted.Eagerly, replay = 0)
 
-  //  val pollState: SharedFlow<Pair<UUID, CurrentSyncJobStatus>> =
-  //    _oneTimeSyncTrigger
-  //      .flatMapLatest {
-  //        // Destructure the Pair to get both the Flow and UUID
-  //        val (statusFlow, uuid) = Sync.oneTimeSync<DemoFhirSyncWorker>(
-  //          context = application.applicationContext
-  //        )
-  //
-  //        // Map each status emission to include the UUID as a Pair
-  //        statusFlow.map { status ->
-  //          Pair(uuid, status) // Create Pair with UUID and status
-  //        }
-  //      }
-  //      .shareIn(viewModelScope, SharingStarted.Eagerly, replay = 0)
-
   fun triggerOneTimeSync() {
     viewModelScope.launch { _oneTimeSyncTrigger.emit(true) }
   }

From 502215a8038c01804a6f5cace6cf3a121828e284 Mon Sep 17 00:00:00 2001
From: Santosh Pingle <spingle@google.com>
Date: Fri, 22 Nov 2024 15:09:35 +0530
Subject: [PATCH 3/4] datastore to store uuid.

---
 .../fhir/demo/PeriodicSyncViewModel.kt        | 37 +++++++--------
 .../fhir/demo/SyncFragmentViewModel.kt        | 11 ++---
 .../android/fhir/sync/SyncInstrumentedTest.kt | 22 ++++-----
 .../google/android/fhir/sync/FhirDataStore.kt | 26 +++++++++++
 .../java/com/google/android/fhir/sync/Sync.kt | 45 +++++++++++++++----
 5 files changed, 97 insertions(+), 44 deletions(-)

diff --git a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
index 6406056499..efcb19b651 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
@@ -32,12 +32,9 @@ import com.google.android.fhir.sync.Sync
 import com.google.android.fhir.sync.SyncJobStatus
 import java.util.*
 import java.util.concurrent.TimeUnit
+import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.MutableStateFlow
-import kotlinx.coroutines.flow.SharedFlow
-import kotlinx.coroutines.flow.SharingStarted
 import kotlinx.coroutines.flow.StateFlow
-import kotlinx.coroutines.flow.map
-import kotlinx.coroutines.flow.shareIn
 import kotlinx.coroutines.launch
 import timber.log.Timber
 
@@ -45,28 +42,30 @@ class PeriodicSyncViewModel(application: Application) : AndroidViewModel(applica
 
   private val _uiStateFlow = MutableStateFlow(PeriodicSyncUiState())
   val uiStateFlow: StateFlow<PeriodicSyncUiState> = _uiStateFlow
-  private var periodicSyncJobId: UUID? = null
-  private val pollPeriodicSyncJobStatus: SharedFlow<PeriodicSyncJobStatus> by lazy {
-    Sync.periodicSync<DemoFhirSyncWorker>(
-        context = application.applicationContext,
+
+  private val _pollPeriodicSyncJobStatus = MutableSharedFlow<PeriodicSyncJobStatus>(replay = 10)
+
+  init {
+    viewModelScope.launch { initializePeriodicSync() }
+  }
+
+  private suspend fun initializePeriodicSync() {
+    val periodicSyncJobStatusFlow =
+      Sync.periodicSync<DemoFhirSyncWorker>(
+        context = getApplication<Application>().applicationContext,
         periodicSyncConfiguration =
           PeriodicSyncConfiguration(
             syncConstraints = Constraints.Builder().build(),
             repeat = RepeatInterval(interval = 15, timeUnit = TimeUnit.MINUTES),
           ),
       )
-      .let { (statusFlow, uuid) ->
-        periodicSyncJobId = uuid
-        statusFlow.map { status ->
-          status // Return status directly, preserving the original signature
-        }
-      }
-      .shareIn(viewModelScope, SharingStarted.Eagerly, replay = 10)
+
+    periodicSyncJobStatusFlow.collect { status -> _pollPeriodicSyncJobStatus.emit(status) }
   }
 
   fun collectPeriodicSyncJobStatus() {
     viewModelScope.launch {
-      pollPeriodicSyncJobStatus.collect { periodicSyncJobStatus ->
+      _pollPeriodicSyncJobStatus.collect { periodicSyncJobStatus ->
         Timber.d(
           "currentSyncJobStatus: ${periodicSyncJobStatus.currentSyncJobStatus}  lastSyncJobStatus ${periodicSyncJobStatus.lastSyncJobStatus}",
         )
@@ -93,8 +92,10 @@ class PeriodicSyncViewModel(application: Application) : AndroidViewModel(applica
   }
 
   fun cancelPeriodicSyncJob() {
-    periodicSyncJobId?.let {
-      Sync.cancelWorkById(getApplication<FhirApplication>().applicationContext, it)
+    viewModelScope.launch {
+      Sync.cancelPeriodicSync<DemoFhirSyncWorker>(
+        getApplication<FhirApplication>().applicationContext,
+      )
     }
   }
 
diff --git a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
index b849a88598..021b57616c 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
@@ -55,12 +55,9 @@ class SyncFragmentViewModel(application: Application) : AndroidViewModel(applica
   val pollState: SharedFlow<CurrentSyncJobStatus> =
     _oneTimeSyncTrigger
       .flatMapLatest {
-        val (statusFlow, uuid) =
-          Sync.oneTimeSync<DemoFhirSyncWorker>(
-            context = application.applicationContext,
-          )
-        oneTimeSyncUuid = uuid
-        statusFlow
+        Sync.oneTimeSync<DemoFhirSyncWorker>(
+          context = application.applicationContext,
+        )
       }
       .map { it }
       .shareIn(viewModelScope, SharingStarted.Eagerly, replay = 0)
@@ -70,7 +67,7 @@ class SyncFragmentViewModel(application: Application) : AndroidViewModel(applica
   }
 
   fun cancelOneTimeSyncWork() {
-    oneTimeSyncUuid?.let { Sync.cancelWorkById(getApplication(), it) }
+    viewModelScope.launch { Sync.cancelOneTimeSync<DemoFhirSyncWorker>(getApplication()) }
   }
 
   /** Emits last sync time. */
diff --git a/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt b/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt
index 382dbd1608..0e761d6f42 100644
--- a/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt
+++ b/engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt
@@ -86,7 +86,7 @@ class SyncInstrumentedTest {
     WorkManagerTestInitHelper.initializeTestWorkManager(context)
     val workManager = WorkManager.getInstance(context)
     runBlocking {
-      val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+      val statusFlow = Sync.oneTimeSync<TestSyncWorker>(context = context)
       statusFlow
         .transformWhile { status ->
           emit(status is CurrentSyncJobStatus.Succeeded)
@@ -104,7 +104,7 @@ class SyncInstrumentedTest {
     WorkManagerTestInitHelper.initializeTestWorkManager(context)
     val states = mutableListOf<CurrentSyncJobStatus>()
     runBlocking {
-      val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+      val statusFlow = Sync.oneTimeSync<TestSyncWorker>(context = context)
       launch {
         statusFlow
           .transformWhile { status ->
@@ -132,7 +132,7 @@ class SyncInstrumentedTest {
 
       // First one-time sync
       launch {
-          val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+          val statusFlow = Sync.oneTimeSync<TestSyncWorker>(context = context)
           statusFlow.collect { status ->
             states.add(status)
             if (status is CurrentSyncJobStatus.Succeeded) {
@@ -144,7 +144,7 @@ class SyncInstrumentedTest {
 
       // Second one-time sync
       launch {
-          val (statusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+          val statusFlow = Sync.oneTimeSync<TestSyncWorker>(context = context)
           statusFlow.collect { status ->
             nextExecutionStates.add(status)
             if (status is CurrentSyncJobStatus.Succeeded) {
@@ -165,7 +165,7 @@ class SyncInstrumentedTest {
     val states = mutableListOf<CurrentSyncJobStatus>()
 
     runBlocking {
-      val (statusFlow, _) =
+      val statusFlow =
         Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
           context = context,
           retryConfiguration =
@@ -207,7 +207,7 @@ class SyncInstrumentedTest {
       val nextExecutionStates = mutableListOf<CurrentSyncJobStatus>()
 
       launch {
-          val (statusFlow, _) =
+          val statusFlow =
             Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
               context = context,
               retryConfiguration =
@@ -232,7 +232,7 @@ class SyncInstrumentedTest {
         .join()
 
       launch {
-          val (nextStatusFlow, _) =
+          val nextStatusFlow =
             Sync.oneTimeSync<TestSyncWorkerForDownloadFailing>(
               context = context,
               retryConfiguration =
@@ -267,7 +267,7 @@ class SyncInstrumentedTest {
     val states = mutableListOf<PeriodicSyncJobStatus>()
     // run and wait for periodic worker to finish
     runBlocking {
-      val (flow, _) =
+      val flow =
         Sync.periodicSync<TestSyncWorker>(
           context = context,
           periodicSyncConfiguration =
@@ -300,7 +300,7 @@ class SyncInstrumentedTest {
     val states = mutableListOf<PeriodicSyncJobStatus>()
 
     runBlocking {
-      val (statusFlow, _) =
+      val statusFlow =
         Sync.periodicSync<TestSyncWorkerForDownloadFailing>(
           context = context,
           periodicSyncConfiguration =
@@ -338,7 +338,7 @@ class SyncInstrumentedTest {
 
     // Run and wait for periodic worker to finish
     runBlocking {
-      val (statusFlow, periodicWorkerId) =
+      val statusFlow =
         Sync.periodicSync<TestSyncWorker>(
           context = context,
           periodicSyncConfiguration =
@@ -369,7 +369,7 @@ class SyncInstrumentedTest {
 
     // Start and complete a one-time job, and verify it does not remove the periodic worker
     runBlocking {
-      val (oneTimeStatusFlow, _) = Sync.oneTimeSync<TestSyncWorker>(context = context)
+      val oneTimeStatusFlow = Sync.oneTimeSync<TestSyncWorker>(context = context)
 
       oneTimeStatusFlow
         .transformWhile { status ->
diff --git a/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt b/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt
index 5cb1245796..bae890d42f 100644
--- a/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt
+++ b/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt
@@ -23,6 +23,7 @@ import androidx.datastore.preferences.core.stringPreferencesKey
 import androidx.datastore.preferences.preferencesDataStore
 import java.io.IOException
 import java.time.OffsetDateTime
+import java.util.*
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.catch
 import kotlinx.coroutines.flow.first
@@ -100,6 +101,31 @@ internal class FhirDataStore(context: Context) {
     runBlocking { dataStore.edit { pref -> pref[lastSyncTimestampKey] = datetime.toString() } }
   }
 
+  /**
+   * Stores the given UUID in DataStore.
+   *
+   * @param uuid The UUID to store.
+   * @param workIdKey The key used to store the UUID.
+   */
+  @PublishedApi
+  internal suspend fun storeWorkId(uuid: UUID, workIdKey: String) {
+    dataStore.edit { preferences ->
+      preferences[stringPreferencesKey("$workIdKey-key")] = uuid.toString()
+    }
+  }
+
+  /**
+   * Fetches the stored UUID from DataStore.
+   *
+   * @param workIdKey The key used to fetch the UUID.
+   * @return The stored UUID, or null if not found.
+   */
+  @PublishedApi
+  internal suspend fun fetchWorkId(workIdKey: String): UUID? {
+    val preferences = dataStore.data.first()
+    return preferences[stringPreferencesKey("$workIdKey-key")]?.let { UUID.fromString(it) }
+  }
+
   companion object {
     private const val FHIR_PREFERENCES_NAME = "FHIR_ENGINE_PREF_DATASTORE"
     private const val LAST_SYNC_TIMESTAMP = "LAST_SYNC_TIMESTAMP"
diff --git a/engine/src/main/java/com/google/android/fhir/sync/Sync.kt b/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
index fc8396a4ae..357b7c1ecb 100644
--- a/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
+++ b/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
@@ -66,11 +66,11 @@ object Sync {
    * @param retryConfiguration configuration to guide the retry mechanism, or `null` to stop retry.
    * @return a [Flow] of [CurrentSyncJobStatus]
    */
-  inline fun <reified W : FhirSyncWorker> oneTimeSync(
+  suspend inline fun <reified W : FhirSyncWorker> oneTimeSync(
     context: Context,
     retryConfiguration: RetryConfiguration? = defaultRetryConfiguration,
-  ): Pair<Flow<CurrentSyncJobStatus>, UUID> {
-    val uniqueWorkName = "${W::class.java.name}-oneTimeSync"
+  ): Flow<CurrentSyncJobStatus> {
+    val uniqueWorkName = createSyncUniqueName<W>("oneTimeSync")
     val flow = getWorkerInfo(context, uniqueWorkName)
     val oneTimeWorkRequest =
       createOneTimeWorkRequest(retryConfiguration, W::class.java, uniqueWorkName)
@@ -81,7 +81,8 @@ object Sync {
         oneTimeWorkRequest,
       )
     val workId = oneTimeWorkRequest.id
-    return Pair(combineSyncStateForOneTimeSync(context, uniqueWorkName, flow), workId)
+    FhirEngineProvider.getFhirDataStore(context).storeWorkId(workId, uniqueWorkName)
+    return combineSyncStateForOneTimeSync(context, uniqueWorkName, flow)
   }
 
   /**
@@ -95,11 +96,11 @@ object Sync {
    * @return a [Flow] of [PeriodicSyncJobStatus]
    */
   @ExperimentalCoroutinesApi
-  inline fun <reified W : FhirSyncWorker> periodicSync(
+  suspend inline fun <reified W : FhirSyncWorker> periodicSync(
     context: Context,
     periodicSyncConfiguration: PeriodicSyncConfiguration,
-  ): Pair<Flow<PeriodicSyncJobStatus>, UUID> {
-    val uniqueWorkName = "${W::class.java.name}-periodicSync"
+  ): Flow<PeriodicSyncJobStatus> {
+    val uniqueWorkName = createSyncUniqueName<W>("periodicSync")
     val flow = getWorkerInfo(context, uniqueWorkName)
     val periodicWorkRequest =
       createPeriodicWorkRequest(periodicSyncConfiguration, W::class.java, uniqueWorkName)
@@ -110,7 +111,30 @@ object Sync {
         periodicWorkRequest,
       )
     val workId = periodicWorkRequest.id
-    return Pair(combineSyncStateForPeriodicSync(context, uniqueWorkName, flow), workId)
+    FhirEngineProvider.getFhirDataStore(context).storeWorkId(workId, uniqueWorkName)
+    return combineSyncStateForPeriodicSync(context, uniqueWorkName, flow)
+  }
+
+  suspend inline fun <reified W : FhirSyncWorker> cancelOneTimeSync(context: Context) {
+    cancelSync<W>(context, "oneTimeSync")
+  }
+
+  suspend inline fun <reified W : FhirSyncWorker> cancelPeriodicSync(context: Context) {
+    cancelSync<W>(context, "periodicSync")
+  }
+
+  @PublishedApi
+  internal suspend inline fun <reified W : FhirSyncWorker> cancelSync(
+    context: Context,
+    syncType: String,
+  ) {
+    val uniqueWorkName = createSyncUniqueName<W>(syncType)
+    val workId = FhirEngineProvider.getFhirDataStore(context).fetchWorkId(uniqueWorkName)
+    if (workId != null) {
+      WorkManager.getInstance(context).cancelWorkById(workId)
+    } else {
+      Timber.w("No Work ID found for uniqueWorkName: $uniqueWorkName")
+    }
   }
 
   fun cancelWorkById(context: Context, workId: UUID) {
@@ -352,4 +376,9 @@ object Sync {
         else -> error("Inconsistent terminal syncJobStatus : $lastSyncJobStatus")
       }
     }
+
+  @PublishedApi
+  internal inline fun <reified W : FhirSyncWorker> createSyncUniqueName(syncType: String): String {
+    return "${W::class.java.name}-$syncType"
+  }
 }

From 59aab1535109ffad2da1fb74f0f33fcb5ee4f947 Mon Sep 17 00:00:00 2001
From: Santosh Pingle <spingle@google.com>
Date: Mon, 25 Nov 2024 16:30:49 +0530
Subject: [PATCH 4/4] code cleanup.

---
 .../android/fhir/demo/PeriodicSyncViewModel.kt   |  1 -
 .../com/google/android/fhir/demo/SyncFragment.kt |  4 ++--
 .../android/fhir/demo/SyncFragmentViewModel.kt   |  2 --
 .../google/android/fhir/sync/FhirDataStore.kt    | 16 +++-------------
 .../java/com/google/android/fhir/sync/Sync.kt    |  9 ---------
 5 files changed, 5 insertions(+), 27 deletions(-)

diff --git a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
index efcb19b651..4099b79dd6 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/PeriodicSyncViewModel.kt
@@ -30,7 +30,6 @@ import com.google.android.fhir.sync.PeriodicSyncJobStatus
 import com.google.android.fhir.sync.RepeatInterval
 import com.google.android.fhir.sync.Sync
 import com.google.android.fhir.sync.SyncJobStatus
-import java.util.*
 import java.util.concurrent.TimeUnit
 import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.MutableStateFlow
diff --git a/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt b/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt
index 53eac823c8..7e0ab120e7 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/SyncFragment.kt
@@ -55,7 +55,7 @@ class SyncFragment : Fragment() {
     }
     observeLastSyncTime()
     launchAndRepeatStarted(
-      { syncFragmentViewModel.pollState.collect(::updateSyncJobStatus) },
+      { syncFragmentViewModel.pollState.collect(::collectSyncJobStatus) },
     )
   }
 
@@ -76,7 +76,7 @@ class SyncFragment : Fragment() {
     }
   }
 
-  private fun updateSyncJobStatus(currentSyncJobStatus: CurrentSyncJobStatus) {
+  private fun collectSyncJobStatus(currentSyncJobStatus: CurrentSyncJobStatus) {
     Timber.d("currentSyncJobStatus: $currentSyncJobStatus")
     // Update status text
     val statusTextView = requireView().findViewById<TextView>(R.id.current_status)
diff --git a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
index 021b57616c..d684e09ff3 100644
--- a/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
+++ b/demo/src/main/java/com/google/android/fhir/demo/SyncFragmentViewModel.kt
@@ -27,7 +27,6 @@ import com.google.android.fhir.sync.CurrentSyncJobStatus
 import com.google.android.fhir.sync.Sync
 import java.time.OffsetDateTime
 import java.time.format.DateTimeFormatter
-import java.util.*
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.channels.BufferOverflow
 import kotlinx.coroutines.flow.MutableSharedFlow
@@ -41,7 +40,6 @@ import kotlinx.coroutines.launch
 /** View model for [MainActivity]. */
 @OptIn(ExperimentalCoroutinesApi::class)
 class SyncFragmentViewModel(application: Application) : AndroidViewModel(application) {
-  private var oneTimeSyncUuid: UUID? = null
   private val _lastSyncTimestampLiveData = MutableLiveData<String>()
   val lastSyncTimestampLiveData: LiveData<String>
     get() = _lastSyncTimestampLiveData
diff --git a/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt b/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt
index bae890d42f..857d529540 100644
--- a/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt
+++ b/engine/src/main/java/com/google/android/fhir/sync/FhirDataStore.kt
@@ -23,7 +23,7 @@ import androidx.datastore.preferences.core.stringPreferencesKey
 import androidx.datastore.preferences.preferencesDataStore
 import java.io.IOException
 import java.time.OffsetDateTime
-import java.util.*
+import java.util.UUID
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.catch
 import kotlinx.coroutines.flow.first
@@ -101,12 +101,7 @@ internal class FhirDataStore(context: Context) {
     runBlocking { dataStore.edit { pref -> pref[lastSyncTimestampKey] = datetime.toString() } }
   }
 
-  /**
-   * Stores the given UUID in DataStore.
-   *
-   * @param uuid The UUID to store.
-   * @param workIdKey The key used to store the UUID.
-   */
+  /** Stores the given UUID in DataStore. */
   @PublishedApi
   internal suspend fun storeWorkId(uuid: UUID, workIdKey: String) {
     dataStore.edit { preferences ->
@@ -114,12 +109,7 @@ internal class FhirDataStore(context: Context) {
     }
   }
 
-  /**
-   * Fetches the stored UUID from DataStore.
-   *
-   * @param workIdKey The key used to fetch the UUID.
-   * @return The stored UUID, or null if not found.
-   */
+  /** Fetches the stored UUID from DataStore. */
   @PublishedApi
   internal suspend fun fetchWorkId(workIdKey: String): UUID? {
     val preferences = dataStore.data.first()
diff --git a/engine/src/main/java/com/google/android/fhir/sync/Sync.kt b/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
index 357b7c1ecb..eb1028e81b 100644
--- a/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
+++ b/engine/src/main/java/com/google/android/fhir/sync/Sync.kt
@@ -137,10 +137,6 @@ object Sync {
     }
   }
 
-  fun cancelWorkById(context: Context, workId: UUID) {
-    WorkManager.getInstance(context).cancelWorkById(workId)
-  }
-
   /**
    * Retrieves the work information for a specific unique work name as a flow of pairs containing
    * the work state and the corresponding progress data if available.
@@ -195,7 +191,6 @@ object Sync {
           createSyncStateForPeriodicSync(
             workerInfoSyncJobStatusPairFromWorkManager.first,
             workerInfoSyncJobStatusPairFromWorkManager.second,
-            syncJobStatusFromDataStore,
           ),
       )
     }
@@ -333,11 +328,7 @@ object Sync {
   private fun createSyncStateForPeriodicSync(
     workInfoState: WorkInfo.State,
     syncJobStatusFromWorkManager: SyncJobStatus?,
-    syncJobStatusFromDataStore: SyncJobStatus?,
   ): CurrentSyncJobStatus {
-    Timber.d(
-      "currentSyncJobStatus : $syncJobStatusFromWorkManager syncJobStatusFromDataStore: $syncJobStatusFromDataStore workInfoState: $workInfoState",
-    )
     return when (workInfoState) {
       WorkInfo.State.ENQUEUED -> Enqueued
       WorkInfo.State.RUNNING -> {