Bring back track filtering #965
Labels
bug
Something isn't working
Comments
|
Re. 1 The filter tracks box was temporarily removed because it was not working correctly in all cases and was causing issues with other features we wanted to build. It will be back in future versions when we figure out how to bring it back without the bugs. Re 2 and 3) These seem like bugs we should fix. |
|
|
primiano
pushed a commit
that referenced
this issue
Dec 13, 2024
This missing where clause meant the selected duration was ~almost always wrong because there would usually be a different event at the same timestamp. Bug: #965 Change-Id: I0fc109ec68ee9d229ff67e24e479a927c4965485
primiano
pushed a commit
that referenced
this issue
Dec 13, 2024
This is a tricky UX decision because you could argue you want this. However, IMO most of the time people create a note to mark that time point, not because they actually want to annotate it. By moving focus, we also make it much harder to actually delete the note as you need to click the note *twice* to be able to delete it (once to select, once to remove focus from text box). Making the focus explicit makes this much more obvious to the user that the focus is on the box so other hotkeys will not work: tbh I did not even notice that the focus was being stolen for several minutes while debugging this issue. Change-Id: I01ae9318b59b166ddd7d7c244d0c287d25f6857f Bug: #965
|
Fixes for 2) and 3) have landed, will cherry pick to canary and stable.
|
LalitMaganti
changed the title
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.perfetto
that referenced
this issue
Dec 18, 2024
This is a tricky UX decision because you could argue you want this. However, IMO most of the time people create a note to mark that time point, not because they actually want to annotate it. By moving focus, we also make it much harder to actually delete the note as you need to click the note *twice* to be able to delete it (once to select, once to remove focus from text box). Making the focus explicit makes this much more obvious to the user that the focus is on the box so other hotkeys will not work: tbh I did not even notice that the focus was being stolen for several minutes while debugging this issue. Change-Id: I01ae9318b59b166ddd7d7c244d0c287d25f6857f Bug: google/perfetto#965 (cherry picked from commit 547551d)
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.perfetto
that referenced
this issue
Dec 18, 2024
This missing where clause meant the selected duration was ~almost always wrong because there would usually be a different event at the same timestamp. Bug: google/perfetto#965 Change-Id: I0fc109ec68ee9d229ff67e24e479a927c4965485 (cherry picked from commit 5370bad)
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.perfetto
that referenced
this issue
Dec 18, 2024
This is a tricky UX decision because you could argue you want this. However, IMO most of the time people create a note to mark that time point, not because they actually want to annotate it. By moving focus, we also make it much harder to actually delete the note as you need to click the note *twice* to be able to delete it (once to select, once to remove focus from text box). Making the focus explicit makes this much more obvious to the user that the focus is on the box so other hotkeys will not work: tbh I did not even notice that the focus was being stolen for several minutes while debugging this issue. Change-Id: I01ae9318b59b166ddd7d7c244d0c287d25f6857f Bug: google/perfetto#965 (cherry picked from commit 547551d)
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.perfetto
that referenced
this issue
Dec 18, 2024
This missing where clause meant the selected duration was ~almost always wrong because there would usually be a different event at the same timestamp. Bug: google/perfetto#965 Change-Id: I0fc109ec68ee9d229ff67e24e479a927c4965485 (cherry picked from commit 5370bad)
|
This filtering function is very convenient, and we really need it |
|
The track filter is now back and available on the autopush channel. However it's now hidden behind a popup as it needs to share screen real estate with the workspace selector. 
|
|
Thank you for your efforts and timely updates.
Wait Behind
***@***.***
…------------------ 原始邮件 ------------------
发件人: "google/perfetto" ***@***.***>;
发送时间: 2025年1月15日(星期三) 凌晨5:50
***@***.***>;
抄送: "Wait ***@***.******@***.***>;
主题: Re: [google/perfetto] Bring back track filtering (Issue #965)
The track filter is now back and available on the autopush channel. However it's now hidden behind a popup as it needs to share screen real estate with the workspace selector.
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My perfetto is in "v48.1-4228a730f" today, and many BAD things happen:
filter(top left) box is gone;
pressing 'M' after click cannot mark the section, but only a single moment;
pressing 'DEL' cannot delete a marker
I used to delete a span note by pressing the 'DEL' key, but now it fails to work. I have to use the mouse to click the 'remove' button.
The text was updated successfully, but these errors were encountered: