Storage: ListBucketsForProjects pagination broken, causes infinite loop

[BrandonY]

What component of google-cloud-cpp is this related to?

Storage

Describe the bug

Iterating over the result of ListBucketsForProjects repeats the first 1000 results forever.

To Reproduce Steps to reproduce the behavior:

1. Create a GCS project with 1001 buckets in it.
2. Run this code:

  for (auto&& bucket_metadata : client.ListBucketsForProject(project_id)) {
    if (!bucket_metadata) throw std::move(bucket_metadata).status();
    std::cout << bucket_metadata->name() << "\n";
  }

This will print out the same 1000 bucket names in an infinite loop.

Expected behavior Program prints out 1001 bucket names and halts.

Operating system: Debian 6.1.106-3

What compiler and version are you using? Bazel

What version of google-cloud-cpp are you using? google-cloud-cpp-2.33.0