-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stream): Fix table#createReadStream with startIndex #1178
base: main
Are you sure you want to change the base?
fix(stream): Fix table#createReadStream with startIndex #1178
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
acb1d55
to
83ece1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks promising! We're going to need unit tests and integration tests before moving forward. It may be a while before I can write them myself, but if you'd like to take a look, I'd start by adding a unit test around here:
Line 1969 in df1dcd3
it('should make correct API request', done => { |
@maximebedard do still have plans to write tests for this ? I can take this over. |
Identical PR to #1100, but for table#createReadStream with a startIndex.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1099 🦕