feat(composer): match any command #733
Conversation
wojpawlik
changed the title
Composer): match any command
| return true; | ||
| let index = cmd.indexOf("@"); | ||
| if (index === -1) { | ||
| index = Infinity; |
There was a problem hiding this comment.
This is a big of a hack, isn't it?
There was a problem hiding this comment.
Any argument value that is less than
0or greater thanstr.lengthis treated as if it were0andstr.length, respectively.
| index = Infinity; | |
| index = cmd.length; |
undefined would require adding a type annotation.
| @@ -110,7 +110,7 @@ describe("Composer types", () => { | |||
| const channelPostCaption = ctx.channelPost?.caption; | |||
| const channelPostText = ctx.channelPost?.text; | |||
| const match = ctx.match; | |||
| assertType<IsExact<typeof msgText, string>>(true); | |||
| assertType<IsExact<typeof msgText, string | undefined>>(true); | |||
There was a problem hiding this comment.
Could you also assert that ctx.msg.text ?? ctx.msg.caption is string? If it isn't, then I'd like to fix up the filter queries first.
There was a problem hiding this comment.
It's string | undefined, no idea why :(
@carafelix #686 required touching 3 files, not 1 line, and uncovered a bug.
There was a problem hiding this comment.
It's odd to me that this seems to work correctly for entities→text but fails for caption_entities→caption. Smells like
- it's related to bad type distribution or
- the above assumption is wrong
There was a problem hiding this comment.
if (ctx.has(":caption_entities")) ctx.msg.caption actually is string, as expected... Only msg.text ?? msg.caption breaks.
There was a problem hiding this comment.
Changing
grammY/src/temporary_types/message.ts
Line 66 in a55168c
There was a problem hiding this comment.
if (ctx.has(":caption_entities")) ctx.msg.captionactually isstring, as expected... Onlymsg.text ?? msg.captionbreaks.
Very interesting, that fits my intuition, but I'll still have to investigate it properly
Happy new year!
Closes #685