Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rulesete ignores files containing "xml" anywhere in the filename #18

Open
thedavej opened this issue Jul 19, 2018 · 1 comment
Open

Comments

@thedavej
Copy link

<exclude-pattern>*/*.xml</exclude-pattern>

I'm not sure why, but this line causes any files or directories that contain the string "xml" in their name to be ignored. My project directory is "XML-Feed-Tool" and phpcs would ignore all of my files. I was mainly focused on a file named "XmlFeedScanner.php" which was still ignored when copied to a new directory called "testing." If I rename the file to something else, like "test.php" inside the "testing" directory, it works fine. I confirmed that commenting out this line restores functionality in my "Xml-Feed-Tool" project.

@louisl
Copy link
Member

louisl commented Oct 11, 2018

Thanks for the report, I'll take a look when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants