Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The following compilation options are not enabled for grpc.jar #11823

Open
ystttt opened this issue Jan 14, 2025 · 1 comment
Open

The following compilation options are not enabled for grpc.jar #11823

ystttt opened this issue Jan 14, 2025 · 1 comment

Comments

@ystttt
Copy link

ystttt commented Jan 14, 2025

The following compilation options are not enabled for libio_grpc_netty_shaded_netty_xx.so:

  1. BIND_NOW
  2. SP
  3. FS
  4. Ftrapv
  5. Strip

These issues may pose security risks and require further remediation.

@kannanjgithub
Copy link
Contributor

kannanjgithub commented Jan 16, 2025

Can you tell us what method you use to determine what compiler options were used for the shared library? libio_grpc_netty_shaded_netty_xx.so is relocated from upstream Netty distribution.
What do the SP and FS options mean?
Ftrapv deals with overflow handling and the code needs to be prepared for it also for it to work.
Stripping is not related to security. It only matters for file size. In an earlier issue we filed with Netty they decided not to strip all symbols because they are useful for debugging and it didn't add much size. Instead, they just partially strip/avoid the large stuff (PR). We expect no changes to be done here.
We may like to have the Bind now option however, as it would fix an Alpine problem.

(With valuable inputs from @ejona86).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants