-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG handling #305
Comments
This is possibly related to #273 |
why do you try to feed guessit with svg files ? I'm not sure it's guessit responsibility to filter out image filetypes. |
It would be nice to use |
I think it was the behavior in guessit 1.x, but this "feature" has been dropped during the 2.x rewriting. I let the issue open, i'll think about it. |
@Toilal detection of image media types would be helpful for show-art |
I understand and it make sense. It could be based on mimetype, but i fear that it may leads to inconsistent results because mimetype property is delegated to native implementation, and various OS may lead to various results. Maybe we could use a pure python library for mimetype guessing, and then rely on this to solve this issue. |
Maybe this can be useful: https://github.com/cdgriffith/puremagic Shouldn't we detect image extensions as containers as well? |
Kinda forgot about this issue, but @Toilal for filenames you could use
It looks like puremagic also does filename matching, so that could be an option too. |
SVG's are partially understood, with the correct mime type.
e.g. https://upload.wikimedia.org/wikipedia/commons/e/e9/Brodnopis_i_pioro.svg
results are
However it isn't a movie, and the
title
should not containsvg
as that was from the extension.The text was updated successfully, but these errors were encountered: