Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong guess: for grown-ish if the filename contains the release group at the end #640

Open
sandrotosi opened this issue Apr 5, 2020 · 1 comment

Comments

@sandrotosi
Copy link

here's couple of examples:

In [54]: guessit.__version__
Out[54]: '3.1.0'

In [55]: guessit.guessit('grown-ish.s03e01.web.x264-tbs[ettv].mkv')
Out[55]: 
MatchesDict([('release_group', 'grown'),
             ('title', 'ish'),
             ('season', 3),
             ('episode', 1),
             ('source', 'Web'),
             ('video_codec', 'H.264'),
             ('container', 'mkv'),
             ('mimetype', 'video/x-matroska'),
             ('type', 'episode')])

In [56]: guessit.guessit('grown-ish.s03e01.web.x264-tbs.mkv')
Out[56]: 
MatchesDict([('title', 'grown-ish'),
             ('season', 3),
             ('episode', 1),
             ('source', 'Web'),
             ('video_codec', 'H.264'),
             ('release_group', 'tbs'),
             ('container', 'mkv'),
             ('mimetype', 'video/x-matroska'),
             ('type', 'episode')])

notice how removing [ettv] from the tail of the file name, now it's recognized properly

@nachocho
Copy link

nachocho commented Apr 25, 2021

I have some other different examples that fall on this category:

guessit('My Neighbor Totoro 1988 HMC (1080p x265 10bit Tigole).mkv')
guessit('Cat People (1982) (1080p BluRay x265 10bit Tigole).mkv')

produces (note there is no release group):

MatchesDict([('title', 'My Neighbor Totoro'), ('year', 1988), ('alternative_title', 'HMC'), ('screen_size', '1080p'), ('video_codec', 'H.265'), ('color_depth', '10-bit'), ('container', 'mkv'), ('mimetype', 'video/x-matroska'), ('type', 'movie')])
MatchesDict([('title', 'Cat People'), ('year', 1982), ('screen_size', '1080p'), ('source', 'Blu-ray'), ('video_codec', 'H.265'), ('color_depth', '10-bit'), ('container', 'mkv'), ('mimetype', 'video/x-matroska'), ('type', 'movie')])

but this similar example does produce the release group correctly:

guessit('Mortal Kombat (2021) (1080p WEB-DL x265 SAMPA).mkv')

produces:

MatchesDict([('title', 'Mortal Kombat'), ('year', 2021), ('screen_size', '1080p'), ('source', 'Web'), ('video_codec', 'H.265'), ('release_group', 'SAMPA'), ('container', 'mkv'), ('mimetype', 'video/x-matroska'), ('type', 'movie')])

so if I remove "10bit" from the title, the release group is produced correctly:

print(guessit('Cat People (1982) (1080p BluRay x265 Tigole).mkv'))

produces:

MatchesDict([('title', 'Cat People'), ('year', 1982), ('screen_size', '1080p'), ('source', 'Blu-ray'), ('video_codec', 'H.265'), ('release_group', 'Tigole'), ('container', 'mkv'), ('mimetype', 'video/x-matroska'), ('type', 'movie')])

should I raise a new issue instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants