Config assumes M1 Mac

[JLLeitschuh]

If you attempt to install rosetta on a non-M1 mac, the config fails.

macstrap-config/custom-scripts/pre-install-0-setup.sh

Lines 35 to 36 in 0a1b7d1

	# Install Rosetta 2
	softwareupdate --install-rosetta --agree-to-license

Additionally, this line also assumes an M1 mac book pro: eval "$(/opt/homebrew/bin/brew shellenv)"

macstrap-config/configs/dotfiles/.zshrc

Lines 64 to 65 in 9e03377

	# Export brew environment variables
	eval "$(/opt/homebrew/bin/brew shellenv)"

[guylabs]

Yes, it does not support X86 architectures anymore. This config is my personal config as a reference and I'm keeping it up to date with the hardware I have. You'd need to fork from around here 45614f6 as there the config started to support arm64 architecture.

Ok for you to close the issue as not planned ?

[JLLeitschuh]

The only two locations currently causing issues are the locations listed above. Other places in the code seem to attempt to mitigate this. Could something similar be used?

macstrap-config/commands/install.sh

Lines 5 to 11 in 895c739

	if test ! "$(hash brew)"; then
	if isArmArchitecture; then
	eval "$(/opt/homebrew/bin/brew shellenv)"
	else
	eval "$(brew --prefix)/bin/brew shellenv"
	fi
	fi

[guylabs]

Yes we can use that. Feel free to create a pull request with your state what works on x86. That would be great!