Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional variables for adding network to the static list #933

Closed
yaroslav-007 opened this issue Mar 20, 2024 · 2 comments
Closed

Additional variables for adding network to the static list #933

yaroslav-007 opened this issue Mar 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@yaroslav-007
Copy link

Problem

Hello,

We are currently working on issue Add support for smart contract verification #558 in local node repo.

We need to be able to manage sourcifySetup in networks-config.json having as end result:

   {
        "name": "local",
        "displayName": "LOCALNET",
        "url": "http://localhost:5551/",
        "ledgerID": "03",
        "sourcifySetup": {
          "activate": true,
          "repoURL": "http://localhost:10000/",
          "serverURL": "http://localhost:5002/",
          "verifierURL": "http://localhost:1234/#/",
          "chainID": 298
        }
      }

Solution

As there are already DOCKER_LOCAL_MIRROR_NODE_MENU_NAME and DOCKER_LOCAL_MIRROR_NODE_URL, it will be very helpful to have environment variables that will enable us to manage the rest of the values.

Alternatives

No response

@yaroslav-007 yaroslav-007 added the enhancement New feature or request label Mar 20, 2024
@svienot
Copy link
Collaborator

svienot commented Mar 22, 2024

Hi @yaroslav-007

We would like to deprecate the use of the DOCKER_LOCAL_MIRROR_NODE_XXX variables and instead recommend to use a mount point allowing to provide a (complete) custom network configuration to the Explorer.

The impact on Local Node would be to include its own networks-config.json in its repo and add the definition of a volume in its docker-compose.yml, something like:

volumes:
  - ./networks-config.json:/app/networks-config.json

So, assuming you want to keep the same config used by Explorer in production (for mainnet, testnet, previewnet) and add the local node configuration, you can copy the existing config at <hashscan-url>/networks-config.json and just add your custom entry for LOCALNET to it.

Would that be adequate for you?

@yaroslav-007
Copy link
Author

Hello @svienot ,

I am currently using the suggested approach.
As you are planing to deprecate the use of the DOCKER_LOCAL_MIRROR_NODE_XXX variables, I will close this issues.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants