Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test addresses are useless #1515

Open
XMRZombie opened this issue Dec 29, 2024 · 3 comments
Open

Test addresses are useless #1515

XMRZombie opened this issue Dec 29, 2024 · 3 comments

Comments

@XMRZombie
Copy link
Contributor

XMRZombie commented Dec 29, 2024 •
edited
Loading

I'm currently running a version of haveno without the test addresses because i noticed they weren't present for Ethereum, sanity checks seems to work without those files

Maybe the RegexAddressValidator could be good enough to be a validation result
@woodser
Copy link
Contributor

woodser commented Dec 30, 2024

Why remove tests which are present?

@XMRZombie
Copy link
Contributor Author

I removed them because i noticed they werent present on ethereum and it didnt broke the code

@woodser
Copy link
Contributor

woodser commented Dec 31, 2024

But the tests which are present there are valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@woodser @XMRZombie