Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialize payment account payload to comma delimited string #1553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

serialize payment account payload to comma delimited string #1553

wants to merge 1 commit into from
+43 −7

Conversation

abhishek818
Copy link

fixes #1549

@abhishek818 abhishek818 requested a review from woodser as a code owner January 18, 2025 13:27
@abhishek818
Copy link
Author

abhishek818 commented Jan 18, 2025 •
edited
Loading

perhaps the alternative place for this change is 'write' method of PaymentAccountTypeAdaptor class.

@woodser
Copy link
Contributor

woodser commented Jan 18, 2025 •
edited
Loading

perhaps the alternative place for this change is 'write' method of PaymentAccountTypeAdaptor class.

Yeah I think the PaymentAccountTypeAdapter is actually the right place to put it, as a counterpart to reading accepted country codes and trade currencies.

Otherwise I suppose the serialization should at least be part of PaymentAccountPayload.toJson(), but the type adapter is really preferred.

@abhishek818 abhishek818 force-pushed the akg_payment_account_payload_string branch from 675bcd3 to 1af5cef Compare January 19, 2025 12:52
@abhishek818
Copy link
Author

abhishek818 commented Jan 19, 2025 •
edited
Loading

#the PaymentAccountTypeAdapter is actually the right place to put it, as a counterpart to reading accepted country codes and trade currencies.

agreed, done with the changes.

@abhishek818 abhishek818 force-pushed the akg_payment_account_payload_string branch from 1af5cef to 94d3302 Compare January 19, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodser woodser Awaiting requested review from woodser woodser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abhishek818 @woodser