Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getvar type unstable #42

Closed
henry2004y opened this issue Apr 15, 2024 · 1 comment
Closed

getvar type unstable #42

henry2004y opened this issue Apr 15, 2024 · 1 comment

Comments

@henry2004y
Copy link
Owner

henry2004y commented Apr 15, 2024 •
edited
Loading

Similar issue as I had previously in Vlaisator.jl. I noticed that although accessing variables via getvar was tagged with return type Any, it is only because derived types from dictionary and anonymous functions are called; if we go on layer deeper and look at only the selectdim branch, it is type-stable and fast.

A better solution might be using something like named array for each variable output.
@henry2004y henry2004y mentioned this issue Nov 4, 2024
Merged
@henry2004y
Copy link
Owner Author

Fixed in #73 by separating raw data reading and derived data reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henry2004y