Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #46

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Refactoring #46

merged 2 commits into from
Apr 26, 2024

Conversation

henry2004y
Copy link
Owner

  • Move plot utility function into plot/utility.jl
  • Replace = with in in loops
  • Use eachslice if possible

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 65.88%. Comparing base (9629d87) to head (3150a59).

Files Patch % Lines
src/select.jl 40.00% 6 Missing ⚠️
src/plot/utility.jl 90.00% 1 Missing ⚠️
src/vtk.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   66.05%   65.88%   -0.18%     
==========================================
  Files          12       12              
  Lines        2389     2377      -12     
==========================================
- Hits         1578     1566      -12     
  Misses        811      811              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henry2004y henry2004y merged commit 6e42bb4 into master Apr 26, 2024
6 checks passed
@henry2004y henry2004y deleted the refactor branch April 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant