Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with view if calculated break isn't a actual break #3

Open
cmiicbrg opened this issue Dec 6, 2017 · 1 comment
Open

Problem with view if calculated break isn't a actual break #3

cmiicbrg opened this issue Dec 6, 2017 · 1 comment

Comments

@cmiicbrg
Copy link

cmiicbrg commented Dec 6, 2017

Doesn't make sense anymore to use the slot type from SlotDAO::calculateSlots since the calculated breaks can be unlocked by the teacher and might be booked by the student, hence displayed wrongly.
Simple solution is in the attached diff.
ViewController.php.diff.txt

@maphy-psd
Copy link
Collaborator

Thanks for the investigation. Maybe the admin can adjust if teachers can set the breaks themselves or not. Therefore we need the automatic break function.

I think that that every slot is free as default and the teachers can set the breaks. So we have to remove the calculations.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants