Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update topcom Interface to latest topcom version #201

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Oct 18, 2022

This aims to fix #200.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 83.90% // Head: 83.77% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (50360d1) compared to base (7c3685d).
Patch coverage: 85.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   83.90%   83.77%   -0.14%     
==========================================
  Files         159      147      -12     
  Lines       12718    12652      -66     
==========================================
- Hits        10671    10599      -72     
- Misses       2047     2053       +6     
Impacted Files Coverage Δ
TopcomInterface/gap/Tools.gi 73.26% <78.12%> (-1.13%) ⬇️
TopcomInterface/gap/Functions.gi 98.49% <100.00%> (+0.03%) ⬆️
TopcomInterface/tst/testall.g
SheafCohomologyOnToricVarieties/tst/testall.g
CoherentSheavesOnToricVarieties/tst/testall.g
AdditionsForToricVarieties/tst/testall.g
QSMExplorer/tst/testall.g
ToricVarieties/tst/testall.g
SpasmInterface/tst/testall.g
SparseMatrices/tst/testall.g
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HereAround HereAround merged commit 7cbd540 into homalg-project:master Oct 18, 2022
@HereAround HereAround deleted the FixError branch October 18, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with TOPCOM 1.1.1
1 participant