From a77cac318cb9a8c7378092371c3b2f26e335c5d7 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Sat, 21 Dec 2024 00:50:46 +0100 Subject: [PATCH] Avoid using InstallValue on non-plain objects --- GradedModules/gap/Tate.gd | 4 ---- GradedModules/gap/Tate.gi | 4 ++-- Modules/gap/OtherFunctors.gd | 2 -- Modules/gap/OtherFunctors.gi | 2 +- 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/GradedModules/gap/Tate.gd b/GradedModules/gap/Tate.gd index 8c7335b16..48e7518d0 100644 --- a/GradedModules/gap/Tate.gd +++ b/GradedModules/gap/Tate.gd @@ -16,14 +16,10 @@ DeclareGlobalFunction( "_Functor_TateResolution_OnGradedModules" ); DeclareGlobalFunction( "_Functor_TateResolution_OnGradedMaps" ); -DeclareGlobalVariable( "Functor_TateResolution_ForGradedModules" ); - DeclareGlobalFunction( "_Functor_LinearStrandOfTateResolution_OnGradedModules" ); DeclareGlobalFunction( "_Functor_LinearStrandOfTateResolution_OnGradedMaps" ); -DeclareGlobalVariable( "Functor_LinearStrandOfTateResolution_ForGradedModules" ); - # basic operations: diff --git a/GradedModules/gap/Tate.gi b/GradedModules/gap/Tate.gi index d8b1beac0..e204d0bfe 100644 --- a/GradedModules/gap/Tate.gi +++ b/GradedModules/gap/Tate.gi @@ -440,7 +440,7 @@ InstallGlobalFunction( _Functor_TateResolution_OnGradedMaps, ### defines: TateRe end ); -InstallValue( Functor_TateResolution_ForGradedModules, +BindGlobal( "Functor_TateResolution_ForGradedModules", CreateHomalgFunctor( [ "name", "TateResolution" ], [ "category", HOMALG_GRADED_MODULES.category ], @@ -879,7 +879,7 @@ InstallMethod( LinearStrandOfTateResolution, end ); -InstallValue( Functor_LinearStrandOfTateResolution_ForGradedModules, +BindGlobal( "Functor_LinearStrandOfTateResolution_ForGradedModules", CreateHomalgFunctor( [ "name", "LinearStrandOfTateResolution" ], [ "category", HOMALG_GRADED_MODULES.category ], diff --git a/Modules/gap/OtherFunctors.gd b/Modules/gap/OtherFunctors.gd index 4bd101c96..e78e9cf32 100644 --- a/Modules/gap/OtherFunctors.gd +++ b/Modules/gap/OtherFunctors.gd @@ -17,8 +17,6 @@ DeclareGlobalFunction( "_Functor_DirectSum_OnModules" ); DeclareGlobalFunction( "_Functor_DirectSum_OnMaps" ); -DeclareGlobalVariable( "Functor_DirectSum_for_fp_modules" ); - #################################### # # temporary diff --git a/Modules/gap/OtherFunctors.gi b/Modules/gap/OtherFunctors.gi index 25763ee23..bdeed0f18 100644 --- a/Modules/gap/OtherFunctors.gi +++ b/Modules/gap/OtherFunctors.gi @@ -134,7 +134,7 @@ InstallGlobalFunction( _Functor_DirectSum_OnMaps, ### defines: DirectSum (morphi end ); -InstallValue( Functor_DirectSum_for_fp_modules, +BindGlobal( "Functor_DirectSum_for_fp_modules", CreateHomalgFunctor( [ "name", "DirectSum" ], [ "category", HOMALG_MODULES.category ],