Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spans_sent metric #1422

Closed
ebracho opened this issue Nov 12, 2024 · 3 comments
Closed

spans_sent metric #1422

ebracho opened this issue Nov 12, 2024 · 3 comments
Labels
type: enhancement New feature or request
Milestone

Comments

@ebracho
Copy link

ebracho commented Nov 12, 2024

Would it be possible to emit a spans_sent metric? This would give us a way to create triggers based on ingested span volumes.

Is your feature request related to a problem? Please describe.

Need a way to create a trigger based on ingested span volumes.

Describe the solution you'd like

Emit a spans_sent counter metric that increments for each spend sent to Honeycomb's ingestion endpoint.

Describe alternatives you've considered

Create a trigger based on a simple COUNT query

  • Usage queries aren't supported for triggers, no way to disable sample rate adjustments for triggers.

Additional context

@ebracho ebracho added the type: enhancement New feature or request label Nov 12, 2024
@kentquirk kentquirk added this to the v2.9 milestone Nov 14, 2024
@kentquirk
Copy link
Contributor

We like this idea and will try to get it in the next release.

@MikeGoldsmith
Copy link
Contributor

Closing as we already have the libhoney_upstream_messages_sent counter that tracks the number of events sent to Honeycomb. It's part of the standard Refinery Metrics.

@ebracho
Copy link
Author

ebracho commented Nov 22, 2024

Oh perfect, thanks for pointing it out. I noticed that metric before but I didn't realize it was referring to span counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants