Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http1 expose ignore_invalid_headers_in_requests opt #3824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

http1 expose ignore_invalid_headers_in_requests opt #3824

wants to merge 1 commit into from

Conversation

GlenDC
Copy link
Contributor

@GlenDC GlenDC commented Jan 9, 2025 •
edited
Loading

Fixes #3825

@GlenDC GlenDC mentioned this pull request Jan 9, 2025
Open
@seanmonstar
Copy link
Member

This probably requires a newer version of httparse in the Cargo.toml, to the version that method was introduced.

@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from 503f6c3 to 129a448 Compare January 9, 2025 22:05
@GlenDC
Copy link
Contributor Author

GlenDC commented Jan 9, 2025

This probably requires a newer version of httparse in the Cargo.toml, to the version that method was introduced.

Seems so: https://github.com/seanmonstar/httparse/releases/tag/v1.9.0

@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from 129a448 to ac9d487 Compare January 9, 2025 22:06
seanmonstar
seanmonstar requested changes Jan 10, 2025
View reviewed changes
src/client/conn/http1.rs Outdated Show resolved Hide resolved
@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from ac9d487 to c521b50 Compare January 10, 2025 21:50
@GlenDC GlenDC requested a review from seanmonstar January 10, 2025 21:51
@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from c521b50 to be248e7 Compare January 10, 2025 21:52
@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from be248e7 to e8a4206 Compare January 10, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar Awaiting requested review from seanmonstar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignore_invalid_headers option for HTTP/1 server requests
2 participants
@GlenDC @seanmonstar