Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event for lockProof() #86

Closed
jimthematrix opened this issue Sep 26, 2024 · 5 comments
Closed

Add event for lockProof() #86

jimthematrix opened this issue Sep 26, 2024 · 5 comments

Comments

@jimthematrix
Copy link
Contributor

No description provided.

@jimthematrix jimthematrix added the good first issue Good for newcomers label Sep 26, 2024
@chbg
Copy link

chbg commented Sep 27, 2024

Hi there, @jimthematrix !

I’m interested in contributing to this issue, but I would appreciate some clarification. Could you provide more details about what kind of event you would like to be added for lockProof()? Specifically:

  • What data or parameters should the event emit?
  • Are there any specific conditions or actions that should trigger the event?
  • Is there a preferred naming convention or structure for events in this repo?

Thanks in advance for your guidance!

@jimthematrix
Copy link
Contributor Author

@chbg hi Houston, thanks for offering to work on this! if the event includes the proof Hash and the delegate, I think we are in good shape. Looking forward to seeing a PR for this!

@chbg
Copy link

chbg commented Oct 1, 2024

@chbg hi Houston, thanks for offering to work on this! if the event includes the proof Hash and the delegate, I think we are in good shape. Looking forward to seeing a PR for this!

Thanks, @jimthematrix! A brief update: I forked the repo last night and made some changes that I've been testing. I anticipate having a PR committed in the next 24 - 48 hours.

@jimthematrix
Copy link
Contributor Author

@chbg hi Houston, want to give you a heads up that we have started thinking about moving away from the lockProof() approach in favor of locking the states, see #110 for details.

@jimthematrix jimthematrix removed the good first issue Good for newcomers label Dec 16, 2024
@jimthematrix
Copy link
Contributor Author

closing this as the PR for using lockStates() #110 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants