From 8fd3089876faca48241d4e65d5348b761b6d36f5 Mon Sep 17 00:00:00 2001
From: Maxim <me@alzhanov.ru>
Date: Tue, 14 Jan 2025 00:37:03 +0300
Subject: [PATCH] Review changes

---
 .../src/components/layouts/MainLayout.tsx     |  9 ++---
 src/frontend/overlay/src/config.ts            | 33 ++++++++++++++++++-
 2 files changed, 37 insertions(+), 5 deletions(-)

diff --git a/src/frontend/overlay/src/components/layouts/MainLayout.tsx b/src/frontend/overlay/src/components/layouts/MainLayout.tsx
index ba0c0e3f..49e1ae09 100644
--- a/src/frontend/overlay/src/components/layouts/MainLayout.tsx
+++ b/src/frontend/overlay/src/components/layouts/MainLayout.tsx
@@ -116,6 +116,7 @@ export const MainLayout = () => {
         <TransitionGroup component={null}>
             {Object.values(widgets).map((obj) => {
                 const Widget = WIDGETS[obj.type];
+                const location = c.WIDGET_POSITIONS[obj.widgetLocationId];
                 if (Widget === undefined) {
                     return null;
                 }
@@ -132,10 +133,10 @@ export const MainLayout = () => {
                 return <Transition key={obj.widgetId} timeout={Widget.overrideTimeout ?? c.WIDGET_TRANSITION_TIME}>
                     {state =>
                         state !== "exited" && <WidgetWrap
-                            left={c.WIDGET_POSITIONS[obj.widgetLocationId].positionX}
-                            top={c.WIDGET_POSITIONS[obj.widgetLocationId].positionY}
-                            width={c.WIDGET_POSITIONS[obj.widgetLocationId].sizeX}
-                            height={c.WIDGET_POSITIONS[obj.widgetLocationId].sizeY}
+                            left={location.positionX}
+                            top={location.positionY}
+                            width={location.sizeX}
+                            height={location.sizeY}
                             shouldCrop={Widget.shouldCrop}
                             zIndex={Widget.zIndex ?? 0}
                             {...(!Widget.ignoreAnimation && transitionProps[state])}
diff --git a/src/frontend/overlay/src/config.ts b/src/frontend/overlay/src/config.ts
index d60bbcec..c1f0732b 100644
--- a/src/frontend/overlay/src/config.ts
+++ b/src/frontend/overlay/src/config.ts
@@ -23,7 +23,38 @@ function Location(positionX: number, positionY: number, sizeX: number, sizeY: nu
         sizeY: sizeY
     });
 }
-
+/**
+ * Creates a Proxy-wrapped configuration object that can manage nested overrides.
+ *
+ * @param {Record<string, any>} override - An object containing override values for configuration keys.
+ * @returns {Record<string, any>} A proxy object that supports reading and writing nested properties,
+ *                                including dotted paths like "a.b.c".
+ *
+ * **How it works**:
+ * - On `get`: if `target[key]` is not found, it checks if the key is dotted (e.g. "a.b").
+ *   If yes, it extracts the prefix ("a"), looks for any sub-object proxy, and then delegates the remainder ("b") to that sub-proxy.
+ * - On `set`: if the value being set is an object, it recursively wraps it in another proxy, merging any override values that match the dotted path prefix.
+ *
+ * **Usage example**:
+ * ```js
+ * const config = createProxy({
+ *   "featureA.enabled": true,
+ *   "featureB.options": { debug: false }
+ * });
+ *
+ * // Accessing a nested path via dot-notation:
+ * config["featureA.enabled"] // true
+ *
+ * // Setting a nested object:
+ * config.featureB = { options: { debug: true, logLevel: 2 } };
+ *
+ * // Now config.featureB.options will return { debug: true, logLevel: 2 }
+ * ```
+ *
+ * **Potential errors**:
+ * - If you pass in non-object overrides or non-serializable data, it may behave unexpectedly.
+ * - Dot notation relies on the first segment being used as the 'prefix' for the sub-object. Make sure your keys are well-formed.
+ */
 function createProxy(
     override,
     // No known way to infer types from assignment yet.