Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ValidationUtils for validating ThermalGrids #1217

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Extend ValidationUtils for validating ThermalGrids #1217

wants to merge 3 commits into from

Conversation

danielfeismann
Copy link
Member

resolves #1216

@danielfeismann danielfeismann self-assigned this Jan 22, 2025
@danielfeismann danielfeismann added the enhancement New feature or request label Jan 22, 2025
@danielfeismann danielfeismann mentioned this pull request Jan 22, 2025
Draft
@danielfeismann danielfeismann marked this pull request as ready for review January 22, 2025 16:48
@danielfeismann danielfeismann mentioned this pull request Jan 22, 2025
Open
staudtMarius
staudtMarius requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small remarks.

src/main/java/edu/ie3/datamodel/utils/validation/ThermalUnitValidationUtils.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/utils/validation/ThermalUnitValidationUtils.java Outdated Show resolved Hide resolved
staudtMarius
staudtMarius requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small remarks in the new test.

src/test/groovy/edu/ie3/datamodel/utils/validation/ThermalValidationUtilsTest.groovy
ThermalUnitInputTestData.domesticHotWaterStorageInput
]
def cylindricalStorageInput = [
ThermalUnitInputTestData.cylindricalStorageInput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, because the test data name is cylindricStorageInput.

src/test/groovy/edu/ie3/datamodel/utils/validation/ThermalValidationUtilsTest.groovy
Comment on lines +120 to +128
def domesticHotWaterStorageInput = [
ThermalUnitInputTestData.domesticHotWaterStorageInput
]
def cylindricalStorageInput = [
ThermalUnitInputTestData.cylindricalStorageInput
]

ThermalGrid thermalGrid = new ThermalGrid(thermalBus, [thermalHouse], cylindricalStorageInput, domesticHotWaterStorageInput)

Copy link
Member

@staudtMarius staudtMarius Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thermal grid needs to be adapted as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius staudtMarius requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@danielfeismann danielfeismann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend ValidationUtils for validating ThermalGrids
2 participants
@danielfeismann @staudtMarius