-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChapterThumbnail #363
Comments
That might make parsing chapters much slower by either reading the thumbnails or skipping them (slower on network and breaks the reading cache). It may be handled as attachments with just the UID stored in the chapters. Some programs may not remux this properly. Also pictures need more than a Binary storage, it needs also a MIME type. That logic is also found in attachments. |
This was my first thought, because attachments is a good choose to store binary files. (MIME Type is there and so on) |
An element of boolean in nonsense :-) The UID which is set in the ChapterThumbnail must be used by a file writer for the attachment. |
What about "timeline" or "index" thumbnails, i.e. thumbnails which are (more or less) evenly spaced in time? For a proprietary approach, see e.g. https://support.plex.tv/articles/202197528-video-preview-thumbnails/ |
MPC-HC (from v.1.9.9) has now such a thumbnail video preview feature and I like it. |
Yes, the question is really where to store it. Either directly in the Chapters but that makes Chapters huge when most of the time all the player want is seek points. It's often read directly in memory for quick access. Here it requires special care to only keep the elements you want to read of not. You don't want to read a Binary element just to release it right after, you would want to skip right away. A link to attachments would balance this by moving the big data in the Attachment part, which is meant for big binary data, and already handles all kinds of things like the MIME type. The downside of this approach is that if you remove the attachment part (to save space) the Chapters might be left pointing nowhere. Another thing is that if you have multiple video tracks you need to know which track the thumbnail is generated from. |
Since MPC-HC supports the thumbnail preview, there is actually no reason anymore for thumbnails in Matroska. The thumbnails for MultiAVCHD is only a time stamp, in the middle of a chapter. There is no other binary data. But when we add the thumbnail feature it will be the best to store the binary data in the Attachment section, and a Chapter needs a new element to store the link to the Attachment.
|
On most Blu-rays you don't have named chapters, but there is often a thumbnail for each chapter.
We could add a new element
ChapterThumbnail
within theChapterAtom
element.The type is binary.
The text was updated successfully, but these errors were encountered: