Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace allowances #24

Closed
gregsdennis opened this issue Sep 25, 2020 · 4 comments
Closed

Whitespace allowances #24

gregsdennis opened this issue Sep 25, 2020 · 4 comments

Comments

@gregsdennis
Copy link
Collaborator

Do we allow spaces (outside of string literals)? If so, where is whitespace allowed?

I think whitespace in query expressions should be allowed. This would fall in to the context of the query expression syntax.

$[(@length - 1)]
$[?(@.value < 10)]

Maybe inside the union/indexer selector:

$[ 1, 2, 5:7, "prop" ]

Are there any other places where whitespace could be considered useful?

@remorhaz
Copy link
Contributor

It may be convenient to allow spaces between matchers - to allow well-readable multi-line queries for complex cases.

@gregsdennis
Copy link
Collaborator Author

gregsdennis commented Oct 7, 2020

Looks like the current definition of a slice allows whitespace internally, so that 1 : 2 : 3 (with leading and trailing whitespace) is valid.

@cabo
Copy link
Member

cabo commented Nov 9, 2021

Closed in #131 and #132

@cabo cabo closed this as completed Nov 9, 2021
@gregsdennis
Copy link
Collaborator Author

What was the resolution here? Where did we end up allowing whitespace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants