Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Gateway should export the security certificate ARN #3

Open
bdwellons opened this issue Apr 26, 2020 · 1 comment
Open

API Gateway should export the security certificate ARN #3

bdwellons opened this issue Apr 26, 2020 · 1 comment

Comments

@bdwellons
Copy link
Contributor

First off, I want to say thanks for all the InfraBlocks you've made available. Super useful and they've been a great tool to learn on. I actually feel like I know what I'm doing at this point.

So the issue. I'm using infrablocks/terraform-aws-ecs-load-balancer which requires an input variable called service_certificate_arn. I'm also using this module (infrablocks/terraform-aws-api-gateway) which is responsible for generating the certificate needed in the ecs-load-balancer module. However, after creating the certificate, the aws-api-gateway module does not expose the ARN of the certificate that was created. This forces me to have to manually retrieve the certificate ARN from the AWS Console and then hard code the value in my ecs-load-balancer module block.

Can we make the AWS API Gateway module expose the certificate ARN? Or am I potentially missing where I can pick this value up without hardcoding it?

@tobyclemson
Copy link
Member

@bdwellons sorry, I completely missed this for some reason. Thanks for your PRs, I'll take a look this weekend and get them merged in. It seems completely reasonable that you'd want the certificate ARN, not sure why that wasn't there already.

I have since created the terraform-aws-acm-certificate module which in retrospect might be a better approach, i.e., create the certificate first then inject its ARN into any other module that needs it. That might be an alternative approach although that would probably require some changes to this module too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants