Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new user from FB and Google #2

Open
linamy85 opened this issue Mar 14, 2017 · 11 comments
Open

Register new user from FB and Google #2

linamy85 opened this issue Mar 14, 2017 · 11 comments
Assignees
Milestone

Comments

@linamy85
Copy link
Collaborator

linamy85 commented Mar 14, 2017

When receiving new user login from FB and Google,
we save their access_token,
check if it is available,
and generate token for the user (for further authentication)

@linamy85 linamy85 changed the title login and authentication service Register new user from FB and Google Mar 14, 2017
@linamy85 linamy85 added v1.0 and removed v1.0 labels Mar 14, 2017
@linamy85 linamy85 added this to the v1.0 milestone Mar 14, 2017
@linamy85 linamy85 modified the milestones: v0.2, v1.0 Mar 27, 2017
@kjohn01
Copy link

kjohn01 commented Mar 27, 2017

怎麼是這個先做啊~

@linamy85
Copy link
Collaborator Author

這不是很重要嗎@@

@kjohn01
Copy link

kjohn01 commented Mar 27, 2017

我以為簡單的先做XD
而且最重要的我覺得其實是文章~
你想想,如果明天不管怎樣就要上線,
可以不能登入,但不能沒有文章對吧~

@linamy85
Copy link
Collaborator Author

歐但是文章會需要 user,但 user 則不用呀XD

@kjohn01
Copy link

kjohn01 commented Mar 28, 2017

喔喔好的~
不過話說,目前google表單上面的那些文章,有辦法知道知道作者嗎?
知道的話,我們是要先幫他們註冊嗎?

@linamy85
Copy link
Collaborator Author

無法得知,因為當初你們的表單沒有規定一定要登入~

@kjohn01
Copy link

kjohn01 commented Mar 31, 2017

其實好像後來有,所以是有登入的就能知道嗎?知道的話就幫註冊?

@linamy85
Copy link
Collaborator Author

想問幫他註冊的必要性是?

@linamy85
Copy link
Collaborator Author

BTW, 我這邊已經完成囉,也有寫個最純樸的前端測試過了。剩下需要 @Mosoc 接到前端看看哪邊需要再做調整~ 這幾天會把 API document 補起來(有推薦格式嗎?

@kjohn01
Copy link

kjohn01 commented Mar 31, 2017

幫他註冊也不是說必要啦,就只是希望可以找的到哪篇文是誰PO的這樣。
API doc 沒寫過,就先照你熟悉的格式吧~
不知道 @Mosoc 有沒有在看這個repo,可能可以到slack提醒他一下~
另外意思是這個sprint的東西你已經做完了嗎?
那這樣好像可以再多塞一點東西XD
或是這個estimate跟現實差有點多^^“
我們可以再來改進一番~

@Mosoc
Copy link
Member

Mosoc commented Apr 1, 2017

有看啊 不過我做的事情包山包海要花點時間消化
文件可以試看看Swagger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants