You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in meeting between HSDevOps and AppServices, sometimes modules will have different internal and external-facing names. Internal names depend on department or company naming conventions, while external-facing names depend on product and marketing decisions.
The publish command should be updated to set the ImageTitle to the instead of to name the artifact if it exists in the module's module.xml. If not, it should use .
The text was updated successfully, but these errors were encountered:
@isc-eneil@isc-kiyer@isc-tleavitt
Currently the ExternalName is not always a valid package name. For example, the external name for IPM itself is Package Management System, which contains spaces. Which of the following do think is the best?
(a) remove the spaces (and other invalid characters) automatically
(b) prompt the user and ask for manual confirmation
(c) abort renaming attempt and keep using the original name
(d) enforce a new standard that requires ExternalName to be valid package name
Personally I would go for (a) which is easiest to implement at a reasonable cost. (b) is safer but needs more work. (d) means we need to migrate all legacy packages and help them update their ExternalName
@isc-shuliu Great points! My proposal: add a flag for the publish command: -use-external-name (alias: -use-ext). When flag is used, throw error if name is not valid for publishing. Reasoning: many packages likely don't use ExternalName (maybe don't even know about it) OR as you said, don't have it in a valid format for publishing purposes (we have that in HS as well with Unified Care Record, Personal Community etc. as ExternalName values). If a user wants to then use ExternalName for publishing, they can explicitly do so and then get good feedback on requirements to do so. Documentation should be added as well about what a valid name is for publishing. Each repo type also likely has different naming requirements so maybe need a method in the IPublishService interface for determining valid package name.
As discussed in meeting between HSDevOps and AppServices, sometimes modules will have different internal and external-facing names. Internal names depend on department or company naming conventions, while external-facing names depend on product and marketing decisions.
The publish command should be updated to set the ImageTitle to the instead of to name the artifact if it exists in the module's module.xml. If not, it should use .
The text was updated successfully, but these errors were encountered: