Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CapacitorCookies enabled boolean does not seem to work #7821

Open
1 of 3 tasks
BenKlein10 opened this issue Jan 2, 2025 · 3 comments
Open
1 of 3 tasks

[Bug]: CapacitorCookies enabled boolean does not seem to work #7821

BenKlein10 opened this issue Jan 2, 2025 · 3 comments
Labels
needs reproduction needs reproducible example to illustrate the issue

Comments

@BenKlein10
Copy link

Capacitor Version

💊 Capacitor Doctor 💊

Latest Dependencies:

@capacitor/cli: 6.2.0
@capacitor/core: 6.2.0
@capacitor/android: 6.2.0
@capacitor/ios: 6.2.0

Installed Dependencies:

@capacitor/cli: 6.2.0
@capacitor/android: 6.2.0
@capacitor/core: 6.2.0
@capacitor/ios: 6.2.0

[success] iOS looking great! 👌
[success] Android looking great! 👌

Other API Details

No response

Platforms Affected

  • iOS
  • Android
  • Web

Current Behavior

Cookies are stored in the session tab when I don't want it too

Expected Behavior

No cookie should be stored

Project Reproduction

...

Additional Information

Since @capacitor/[email protected], cookies are automatically stored even with the enabled option specified in capacitor.config.json

You added an if condition in this commit but removed it before merging into the main branch, was it on purpose ?
df35496

adding it manually myself get rid of the problem

@markemer markemer added the needs reproduction needs reproducible example to illustrate the issue label Jan 6, 2025
Copy link

ionitron-bot bot commented Jan 6, 2025

This issue needs more information before it can be addressed. In particular, the reporter needs to provide a minimal sample app that demonstrates the issue. If no sample app is provided within 15 days, the issue will be closed.
Please see the Contributing Guide for how to create a Sample App.
Thanks! Ionitron 💙

@ionitron-bot ionitron-bot bot removed the triage label Jan 6, 2025
@Ionitron Ionitron added needs reply needs reply from the user and removed needs reply needs reply from the user labels Jan 6, 2025
@markemer
Copy link
Member

markemer commented Jan 6, 2025

@ItsChaceD can you look at df35496 to see if we goofed there?

@ItsChaceD
Copy link
Contributor

@ItsChaceD can you look at df35496 to see if we goofed there?

Yes looks like I goofed 🤦‍♂️ Here was the PR: #6690
Here is the commit that removed the if statement for no apparent reason 4de13dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction needs reproducible example to illustrate the issue
Projects
None yet
Development

No branches or pull requests

4 participants