Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't hydrate class name in html tag anymore #6091

Open
3 tasks done
christian-bromann opened this issue Jan 10, 2025 · 0 comments
Open
3 tasks done

feat: don't hydrate class name in html tag anymore #6091

christian-bromann opened this issue Jan 10, 2025 · 0 comments
Labels
Help Wanted Request For Comments Seeking commentary on an issue or PR from the community

Comments

@christian-bromann
Copy link
Member

christian-bromann commented Jan 10, 2025

Prerequisites

Describe the Feature Request

Currently Stencil sets a hydrate class name on the html tag do avoid flicker effects in Ionic applications. Ionic uses the following style to enable it:

html:not(.hydrated) body {
  display: none;
}

The problem with this approach is that Next.js applications throw an error as they interpret this as an unintentional.

Describe the Use Case

Especially when components are lazy loaded we have to ensure that applications can load smoothly.

Describe Preferred Solution

We should not block the application from being visible just because there are some Stencil components that take longer to load. I think the best approach here is to just remove this behavior from the appDidLoad function. However this may have an impact on the Ionic project which we need to evaluate.

Describe Alternatives

No response

Related Code

No response

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Jan 10, 2025
@christian-bromann christian-bromann added Request For Comments Seeking commentary on an issue or PR from the community Help Wanted and removed triage labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Request For Comments Seeking commentary on an issue or PR from the community
Projects
None yet
Development

No branches or pull requests

1 participant