You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 26, 2019. It is now read-only.
8[14:15] iggy: I'd make the IDs less generic
8[14:16] iggy: and indent some of that nested jinja
8[14:16] iggy: don't use mapping
8[14:16] iggy: it's a relatively recent addition to jinja
8[14:17] iggy: so you'll end up with people filing bugs saying it broke
8[14:17] iggy: hooray for old Distros that won't die and people that won't upgrade
8[14:18] iggy: take out all those for loop else's
8[14:19] iggy: and I wouldn't use content like that
8[14:19] iggy: use templated files
8[14:19] iggy: and put at the top that the files are managed by salt and shouldn't be altered
8[14:20] iggy: I get not wanting to put mostly useless files in your tree, but it's kind of the standard (and frankly easier to follow than a shit ton of for's/if's/else's/etc all crammed into a content block)
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8[14:15] iggy: I'd make the IDs less generic
8[14:16] iggy: and indent some of that nested jinja
8[14:16] iggy: don't use mapping
8[14:16] iggy: it's a relatively recent addition to jinja
8[14:17] iggy: so you'll end up with people filing bugs saying it broke
8[14:17] iggy: hooray for old Distros that won't die and people that won't upgrade
8[14:18] iggy: take out all those for loop else's
8[14:19] iggy: and I wouldn't use content like that
8[14:19] iggy: use templated files
8[14:19] iggy: and put at the top that the files are managed by salt and shouldn't be altered
8[14:20] iggy: I get not wanting to put mostly useless files in your tree, but it's kind of the standard (and frankly easier to follow than a shit ton of for's/if's/else's/etc all crammed into a content block)
The text was updated successfully, but these errors were encountered: