Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kube-rbac-proxy #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgn
Copy link
Collaborator

@dgn dgn commented Jan 10, 2025

Replaces proxy with controller-runtime functionality. Fixes #502.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.33%. Comparing base (3a54b8b) to head (e349524).

Files with missing lines Patch % Lines
cmd/main.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   75.41%   75.33%   -0.09%     
==========================================
  Files          40       40              
  Lines        2481     2497      +16     
==========================================
+ Hits         1871     1881      +10     
- Misses        518      527       +9     
+ Partials       92       89       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FilipB
Copy link
Collaborator

FilipB commented Jan 13, 2025

@dgn could you please confirm that following can be removed after this?

@dgn
Copy link
Collaborator Author

dgn commented Jan 13, 2025

@dgn could you please confirm that following can be removed after this?

Yep!

@dgn dgn force-pushed the remove-kube-rbac-proxy branch from 289e91d to e616548 Compare January 13, 2025 11:00
@dgn dgn force-pushed the remove-kube-rbac-proxy branch from e616548 to b98d470 Compare January 13, 2025 11:04
@dgn dgn force-pushed the remove-kube-rbac-proxy branch from b98d470 to 6c48a2e Compare January 13, 2025 11:35
@dgn
Copy link
Collaborator Author

dgn commented Jan 13, 2025

/retest

@dgn dgn force-pushed the remove-kube-rbac-proxy branch from 6c48a2e to da32304 Compare January 14, 2025 19:39
@dgn dgn changed the title [WIP] Remove kube-rbac-proxy Remove kube-rbac-proxy Jan 14, 2025
@dgn dgn force-pushed the remove-kube-rbac-proxy branch from da32304 to 4d85108 Compare January 15, 2025 10:26
@dgn
Copy link
Collaborator Author

dgn commented Jan 15, 2025

/retest

1 similar comment
@dgn
Copy link
Collaborator Author

dgn commented Jan 15, 2025

/retest

Replaces proxy with controller-runtime functionality. Fixes istio-ecosystem#502.

Signed-off-by: Daniel Grimm <[email protected]>
@dgn dgn force-pushed the remove-kube-rbac-proxy branch from 4d85108 to e349524 Compare January 17, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy
3 participants