-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kube-rbac-proxy #556
Open
dgn
wants to merge
1
commit into
istio-ecosystem:main
Choose a base branch
from
dgn:remove-kube-rbac-proxy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 75.41% 75.33% -0.09%
==========================================
Files 40 40
Lines 2481 2497 +16
==========================================
+ Hits 1871 1881 +10
- Misses 518 527 +9
+ Partials 92 89 -3 ☔ View full report in Codecov by Sentry. |
dgn
force-pushed
the
remove-kube-rbac-proxy
branch
from
January 13, 2025 11:00
289e91d
to
e616548
Compare
dgn
force-pushed
the
remove-kube-rbac-proxy
branch
from
January 13, 2025 11:04
e616548
to
b98d470
Compare
dgn
force-pushed
the
remove-kube-rbac-proxy
branch
from
January 13, 2025 11:35
b98d470
to
6c48a2e
Compare
/retest |
dgn
force-pushed
the
remove-kube-rbac-proxy
branch
from
January 14, 2025 19:39
6c48a2e
to
da32304
Compare
dgn
force-pushed
the
remove-kube-rbac-proxy
branch
from
January 15, 2025 10:26
da32304
to
4d85108
Compare
/retest |
1 similar comment
/retest |
Replaces proxy with controller-runtime functionality. Fixes istio-ecosystem#502. Signed-off-by: Daniel Grimm <[email protected]>
dgn
force-pushed
the
remove-kube-rbac-proxy
branch
from
January 17, 2025 10:21
4d85108
to
e349524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces proxy with controller-runtime functionality. Fixes #502.