Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might be worth to mention something in the readme #3

Open
Vodes opened this issue Mar 28, 2024 · 2 comments
Open

Might be worth to mention something in the readme #3

Vodes opened this issue Mar 28, 2024 · 2 comments

Comments

@Vodes
Copy link

Vodes commented Mar 28, 2024

I am writing my own app for my own mediaserver stack and I noticed that stuff started crashing with downloaded files.
Then I looked at your implementation in findroid and saw this.

Maybe it might be a good idea to mention that in this repo somewhere? I'm doing it pretty differently from you (and probably not in a good way) in my app so this seems like a thing that just kinda happens regardless of exact implementation.

My implementation for reference https://github.com/Vodes/Styx-2m/blob/d5e82718f698a417a2143dc9edf6c275f272244c/styx2m/src/androidMain/kotlin/moe/styx/styx2m/player/MediaPlayer.android.kt#L193-L213

@jarnedemeulemeester
Copy link
Owner

Ideally I just want to remove the delay code in Findroid. That's why I never documented it.
I just tested it again and I cannot reproduce the crash with the delay code gone 🤔

Is it still crashing for you?

@Vodes
Copy link
Author

Vodes commented May 8, 2024

I really don't feel like building this thing but on the last release it did yeah. Even with a delay it still does on slower devices for some reason. Haven't really gotten around to find a better workaround or whatever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants