Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the popular AmazonWebServicesCredentialsBinding credential types #296

Closed
b-sturgeon opened this issue Aug 22, 2023 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@b-sturgeon
Copy link

What feature do you want to see added?

We manage a Jenkins instance which handles hundreds of pipelines. These pipelines often use AWS credentials from the AWS Credentials plugin like the following example:

withCredentials([[$class: 'AmazonWebServicesCredentialsBinding', credentialsId : AWS_CREDS]]) {
    sh("make deploy_prod")  
 }

Or:

withCredentials([[$class: "AmazonWebServicesCredentialsBinding",
     accessKeyVariable: "AWS_ACCESS_KEY_ID",
     credentialsId    : FOOBAR_ACCESS_CREDS,
     secretKeyVariable: "AWS_SECRET_ACCESS_KEY"]]) {
         sh("""AWS_DEFAULT_REGION=${STACK_REGION} make promote-foobar""")
}

Storing these AWS credentials in AWS would make it easy to rotate them. It is likely possible to use the workarounds listed in https://plugins.jenkins.io/aws-secrets-manager-credentials-provider/#plugin-content-advanced-usage, but is not feasible for us because it would require the rewriting of hundreds of invocations in pipelines we do not own.

Upstream changes

No response

@b-sturgeon b-sturgeon added the enhancement New feature or request label Aug 22, 2023
@cccCody
Copy link

cccCody commented Sep 27, 2023

is this the same as #237?

@chriskilding
Copy link
Contributor

Effectively yes, so I will close this as a duplicate.

@chriskilding chriskilding closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants