From 3fb0f9ff84e5b1dbfacb223552ca1b0042d60deb Mon Sep 17 00:00:00 2001 From: Jeroen Ooms Date: Fri, 7 Jun 2024 18:21:04 +0200 Subject: [PATCH] Fix check --- NAMESPACE | 2 +- NEWS | 2 +- R/V8.R | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NAMESPACE b/NAMESPACE index 94b8761..c8cd55d 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -13,7 +13,7 @@ export(v8) export(wasm) export(wasm_features) if (getRversion() >= "4.3.0" && !is.null(asNamespace("utils")$.AtNames)) S3method(utils::.AtNames,V8) -if (getRversion() >= "4.3.0") S3method(base::`@`, V8) else export("@") +if (getRversion() >= "4.3.0") S3method(base::`@`, V8) import(Rcpp) importFrom(curl,curl) importFrom(jsonlite,fromJSON) diff --git a/NEWS b/NEWS index 107b0fb..3ac6629 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,7 @@ 5.0.0 - Drop support for legacy v8-314 library - Compile with C++20 when available (required as of libv8 version 12.7) - - Enable @ instead of $ syntax for accessing v8 fields + - Enable @ accessor for v8 objects in R >= 4.3.0 4.4.2 - Prevent Fedora from accidentally building against the legacy v8-314 library diff --git a/R/V8.R b/R/V8.R index a8ef782..77f0e88 100644 --- a/R/V8.R +++ b/R/V8.R @@ -321,7 +321,7 @@ print.V8 <- function(x, ...){ } #' @export -#' @rawNamespace if (getRversion() >= "4.3.0") S3method(base::`@`, V8) else export("@") +#' @rawNamespace if (getRversion() >= "4.3.0") S3method(base::`@`, V8) `@.V8` <- function(object, name, ...){ object[[name]] }