Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic numbers in codec functions #9

Open
jmcph4 opened this issue Mar 24, 2019 · 0 comments
Open

Remove magic numbers in codec functions #9

jmcph4 opened this issue Mar 24, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jmcph4
Copy link
Owner

jmcph4 commented Mar 24, 2019

Often, as a quick validation check, the length of a az_bytearray_t will be checked to ensure it's at least three bytes long, due to inference from the actual multiformat specifications themselves. While this is technically valid, the current codebase is now littered with nasty magic numbers.

These belong in a macro constant of some sort, perhaps defined in src/azorian.h.

@jmcph4 jmcph4 added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant