Not an issue, just added DataGroup

[OLaudren]

Hello,
Here attached a few files I wrote to enable the DataGroup management.
Do you think you could integrate them soon?

Thank you,
DataGroup.zip

[joel74]

Hi, OLaudren,

Thanks for creating these. I'll check them out shortly. Just fyi, the normal procedure would be to have your own fork of the project, add your changes to the fork and then make a pull request. Then we all could review the changes and merge them into the main branch. For next time. :)

Cheers,
Joel

[OLaudren]

Hi Joel, Oops, sorry... I found the right way so I will use next time. Sure. Sorry again. Thanks, From: joel [mailto:[email protected]] Sent: 27 April 2017 16:02 To: joel74/POSH-LTM-Rest <[email protected]> Cc: LAUDREN Olivier <[email protected]>; Author <[email protected]> Subject: Re: [joel74/POSH-LTM-Rest] Not an issue, just added DataGroup (#118) Hi, OLaudren, Thanks for creating these. I'll check them out shortly. Just fyi, the normal procedure would be to have your own fork of the project, add your changes to the fork and then make a pull request. Then we all could review the changes and merge them into the main branch. For next time. :) Cheers, Joel — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#118 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AZhvbsJr0uY3HCyGCkrGTU7wkUShd5diks5r0J_ygaJpZM4NKJB6>. Ce message contient des informations confidentielles à l'intention exclusive du destinataire. Il ne peut être utilisé, divulgué ou copié de quelconque façon que ce soit par une personne autre que le destinataire désigné. Si vous n'êtes pas le destinataire désigné, merci de contacter l'expéditeur et d'effacer ce message. L'expéditeur de ce message n'est pas mandaté à représenter le Parlement européen. Dès lors, ce message ne constitue pas nécessairement le point de vue officiel du Parlement européen, ni un engagement juridique opposable à ce dernier. This message contains confidential information intended solely for the attention of the named addressee. It may not be used, disclosed or copied in any way whatsoever by anyone else than the intended addressee. If you are not the intended addressee, please contact the sender and delete this message. The sender of this message is not authorized to represent the European Parliament and therefore this message does not necessarily reflect the official position of the European Parliament and is not legally binding upon it.

[joel74]

Hi, OLaudren,

In testing, I found that the example given for New-DataGroup didn't work. It's passing in http as the type, but the only accepted values for type are ip and string. Let's follow the UI conventions and accept 'Address' (instead of IP), 'Integer', 'String' and 'ExternalFile' as valid types. Sound good?

Thanks
Joel

[OLaudren]

Yes, OK. I guess ExternalFile would imply a "external" DataGroup so it will require other change. :( Olivier. From: joel [mailto:[email protected]] Sent: 27 April 2017 17:25 To: joel74/POSH-LTM-Rest <[email protected]> Cc: LAUDREN Olivier <[email protected]>; Author <[email protected]> Subject: Re: [joel74/POSH-LTM-Rest] Not an issue, just added DataGroup (#118) Hi, OLaudren, In testing, I found that the example given for New-DataGroup didn't work. It's passing in http as the type, but the only accepted values for type are ip and string. Let's follow the UI conventions and accept 'Address' (instead of IP), 'Integer', 'String' and 'ExternalFile' as valid types. Sound good? Thanks Joel — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#118 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AZhvbhurlaKHTc8TRdnJxv4bqr_RTjb7ks5r0LNdgaJpZM4NKJB6>. Ce message contient des informations confidentielles à l'intention exclusive du destinataire. Il ne peut être utilisé, divulgué ou copié de quelconque façon que ce soit par une personne autre que le destinataire désigné. Si vous n'êtes pas le destinataire désigné, merci de contacter l'expéditeur et d'effacer ce message. L'expéditeur de ce message n'est pas mandaté à représenter le Parlement européen. Dès lors, ce message ne constitue pas nécessairement le point de vue officiel du Parlement européen, ni un engagement juridique opposable à ce dernier. This message contains confidential information intended solely for the attention of the named addressee. It may not be used, disclosed or copied in any way whatsoever by anyone else than the intended addressee. If you are not the intended addressee, please contact the sender and delete this message. The sender of this message is not authorized to represent the European Parliament and therefore this message does not necessarily reflect the official position of the European Parliament and is not legally binding upon it.

[joel74]

From the looks of it, accepting an external file for a data group might not be an easy addition. My recommendation would be to fork the project, make your changes so that New-DataGroup accepts 'Address','String', and 'Integer', put in a note that 'ExternalFile' will be supported in the future, update the example and create a pull request for that.

[OLaudren]

I fully agree. Thanks a lot. From: joel [mailto:[email protected]] Sent: 27 April 2017 17:47 To: joel74/POSH-LTM-Rest <[email protected]> Cc: LAUDREN Olivier <[email protected]>; Author <[email protected]> Subject: Re: [joel74/POSH-LTM-Rest] Not an issue, just added DataGroup (#118) From the looks of it, accepting an external file for a data group might not be an easy addition. My recommendation would be to fork the project, make your changes so that New-DataGroup accepts 'Address','String', and 'Integer', put in a note that 'ExternalFile' will be supported in the future, update the example and create a pull request for that. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#118 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AZhvboMoklYEUHGkIhyAV-MaExgs98Faks5r0LiFgaJpZM4NKJB6>. Ce message contient des informations confidentielles à l'intention exclusive du destinataire. Il ne peut être utilisé, divulgué ou copié de quelconque façon que ce soit par une personne autre que le destinataire désigné. Si vous n'êtes pas le destinataire désigné, merci de contacter l'expéditeur et d'effacer ce message. L'expéditeur de ce message n'est pas mandaté à représenter le Parlement européen. Dès lors, ce message ne constitue pas nécessairement le point de vue officiel du Parlement européen, ni un engagement juridique opposable à ce dernier. This message contains confidential information intended solely for the attention of the named addressee. It may not be used, disclosed or copied in any way whatsoever by anyone else than the intended addressee. If you are not the intended addressee, please contact the sender and delete this message. The sender of this message is not authorized to represent the European Parliament and therefore this message does not necessarily reflect the official position of the European Parliament and is not legally binding upon it.

[joel74]

Hi, Olivier,
I'm just checking in to see how this is going.
Cheers,
Joel

[mtengmo]

It would be great if you could add support for datagroups.

[joel74]

Ok. I'll take a look again at what Olivier submitted, and tweak it a bit. I don't think I'll be adding the External File support at this time, though.

[mtengmo]

Thanks, I looked on the code, and it looks like it only exists three functions; Get-Datagroup, New-Datagroup, and Test-Datagroup.
I was more interested in adding/modify/delete data to/from datagroups. Both String and Address types.

[joel74]

@mtengmo , I haven't really used datagroups myself. So what you're interested in is different, I take it, from a Set-DataGroup function, because you're more interested in modifying the actual data, not the properties of the datagroup, is that accurate?

[mtengmo]

Datagroup is similar to a table in sql. You can have three datatypes, (integer, ip or string). IP is just a single column with IPs. String is two columns (string, value). Really powerful to use in irule´s.
I´m interested to add/modify/delete data from already created datagroups.

[colombeen]

Will DataGroup support be added anytime soon? Without it we can't use this module in our environment.

[joel74]

I will try to find some time to look at this soon so maybe in the next few weeks it will be added.