Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra blank line printed #5

Open
jloh opened this issue Aug 18, 2021 · 0 comments · May be fixed by #6
Open

Extra blank line printed #5

jloh opened this issue Aug 18, 2021 · 0 comments · May be fixed by #6

Comments

@jloh
Copy link

jloh commented Aug 18, 2021

First, thanks for the great library!

When using it however a blank newline is constantly printed after the main app. Checkout the example app from the README.md:

image

I think this could be because fmt.Println is used when the text already has a newline appended to it via \n.

go-bitbar/bitbar.go

Line 334 in 48c7546

fmt.Println(output)

I'm using xbar v2.1.4-beta
jloh added a commit to jloh/go-bitbar that referenced this issue Aug 18, 2021
@jloh
Fix blank newline on Render func
56ce761 
Closes johnmccabe#5

- App app lines already get a newline rendered via `\n` so `fmt.Println` was just adding a blank new line at the end
@jloh jloh linked a pull request Aug 18, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix blank newline on Render func jloh/go-bitbar
1 participant
@jloh