Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow functions to accept CompadreM class #10

Closed
wpetry opened this issue Jan 10, 2018 · 2 comments
Closed

allow functions to accept CompadreM class #10

wpetry opened this issue Jan 10, 2018 · 2 comments

Comments

@wpetry
Copy link
Collaborator

wpetry commented Jan 10, 2018

Functions that currently require matU, matF, ... arguments should also accept objects of class CompadreM, automatically parsing the matrix components or failing (with a helpful error) when a necessary component is missing.

Maybe best to write function generics with methods for the manual entry vs. com(p)adre database objects?

@wpetry wpetry changed the title allow functions to accept CompadreM and ComadreM classes allow functions to accept CompadreM and CompadreData classes Jan 10, 2018
@wpetry wpetry changed the title allow functions to accept CompadreM and CompadreData classes allow functions to accept CompadreM class Jan 10, 2018
@tdjames1
Copy link
Collaborator

Yes, the idea was to overload the functions so that they can be used with separate matrix components (which don't necessarily have to originate from COMPADRE) or with the new CompadreM objects.

@jonesor
Copy link
Owner

jonesor commented Feb 22, 2021

This is now taken up with issue #112. Closing here.

@jonesor jonesor closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants