-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search inside playlist #456
Comments
Ohh that's a good idea! Shouldn't be too hard I don't think. |
Does Cmd/Ctrl+F within the playlist work for you @CypherPotato ? |
@jacksongoode hello. I've tried it in the version from commit #913dae1 but couldn't get it working. |
@CypherPotato Which platform are you on? The search should really filter the list completely. Right now it just highlights the items that match.
That seems like a separate context based kind of situation that would be a little tricky to figure out. |
This is addressed in #511; I also found that Cmd/Ctrl+F doesn't work on my devices. The playing from only the filtered part of the playlist doesn't make much sense and could be a very niche use case. However, with the current search filter, it should, as @jacksongoode says, either filter the list by removing the other songs in the playlist or, in my opinion, a far more effective way of doing it would be having an auto-scroll to position a bit like when in VSCode. I am happy to work on this as well. |
Is your feature request related to a problem? Please describe.
There should be a way to search for a song or artist within the playlist or saved songs
Describe the solution you'd like
A separate search bar, or button that opens the search bar, that when searching, filters the results based on what I searched for. When playing a song from these results, play only the filtered part of the playlist.
Describe alternatives you've considered
There is no other way to do this.
Additional context
I'm talking about this button.
The text was updated successfully, but these errors were encountered: