Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with Flask v3 #3

Open
xenophonf opened this issue Sep 7, 2024 · 0 comments · May be fixed by #4
Open

Incompatible with Flask v3 #3

xenophonf opened this issue Sep 7, 2024 · 0 comments · May be fixed by #4

Comments

@xenophonf
Copy link

With the latest version of Flask installed (e.g., version 3.0.3), Python signals an import error when importing Flask-FomanticUI:

src/app.py:24: in <module>
    from flask_fomanticui import FomanticUI
.venv/lib/python3.11/site-packages/flask_fomanticui/__init__.py:35: in <module>
    from .core import *  # noqa
.venv/lib/python3.11/site-packages/flask_fomanticui/core.py:32: in <module>
    from flask import Blueprint, Markup, current_app, url_for
E   ImportError: cannot import name 'Markup' from 'flask' (.venv/lib/python3.11/site-packages/flask/__init__.py)

Cf. pallets/flask#5353 (comment)
xenophonf added a commit to xenophonf/Flask-FomanticUI that referenced this issue Sep 7, 2024
@xenophonf
Switch from flask.Markup to MarkupSafe
cffa469 
[Flask 2.3.0](https://flask.palletsprojects.com/en/3.0.x/changes/#version-2-3-0)
deprecated its Markup class in favor of of MarkupSafe.  This causes an
import error when using Flask-FomanticUI with newer Flask releases.

Fixes juniors90#3
@xenophonf xenophonf linked a pull request Sep 7, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from flask.Markup to MarkupSafe xenophonf/Flask-FomanticUI
1 participant
@xenophonf