We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using XEITHER_OPTIONAL or XEITHER to limit valid values, the validation check doesn't happen when initialising a variable using Method Chaining.
The text was updated successfully, but these errors were encountered:
In https://github.com/jupyter-xeus/xproperty/blob/master/include/xproperty/xproperty.hpp#L182-L194
We could try replacing m_value = arg; and m_value = std::move(arg); with
m_value = arg;
m_value = std::move(arg);
m_value = owner()->template invoke_validators<T>(m_name, arg);
and
m_value = owner()->template invoke_validators<T>(m_name, std::move(arg));
respectively, and add a test.
Sorry, something went wrong.
Do you want to give it a shot @madhur-tandon?
Was going to ask :) I will give it a shot after completing a few things for Mark in the other project.
Mark
No branches or pull requests
When using XEITHER_OPTIONAL or XEITHER to limit valid values, the validation check doesn't happen when initialising a variable using Method Chaining.
The text was updated successfully, but these errors were encountered: