Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add left and right padding to active cell border #7566

Open
andrii-i opened this issue Jan 17, 2025 · 2 comments
Open

Add left and right padding to active cell border #7566

andrii-i opened this issue Jan 17, 2025 · 2 comments

Comments

@andrii-i
Copy link
Contributor

andrii-i commented Jan 17, 2025

Problem

Active cell border does not have left and right padding. As a result, when viewport is narrow active cell border is not displayed on left and right.

Notebook (wide viewport):
Image

Notebook (narrow viewport):
Image

Proposed Solution

Add left and right padding to active cell border similar to JupyterLab. As an added bonus, this would make design language used in lab and notebook more consistent.

JupyterLab:
Image

@jtpio
Copy link
Member

jtpio commented Jan 21, 2025

Thanks @andrii-i for the suggestion 👍

This sounds good. If you would like to open a PR that would be great, thanks!

@andrii-i
Copy link
Contributor Author

andrii-i commented Jan 22, 2025

Feedback during the call: overall sounds good, important to test on WCAG reflow requirements for low width / high zoom viewport https://www.w3.org/WAI/WCAG21/Understanding/reflow.html

320 CSS pixels is equivalent to a starting viewport width of 1280 CSS pixels wide at 400% zoom. For web content which is designed to scroll horizontally (e.g., with vertical text), 256 CSS pixels is equivalent to a starting viewport height of 1024 CSS pixels at 400% zoom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants