Export FCstd to jcad #25
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: martinRenou <[email protected]>
for more information, see https://pre-commit.ci
martinRenou
reviewed
Dec 4, 2024
|
|
||
| try: | ||
| fcstd = FCStd() | ||
| fcstd.load(base64_content=base64_content) |
There was a problem hiding this comment.
Our jupytercad_freecad.freecad.loader module only exposes a load method that reads base 64 data, but it will create a temporary file under the hood before passing it to actual freecad. So we're reading into base 64, writing the file, and reading it again.
We could reduce the complexity of this by introducing e.g. a load_file method to the FCStd that loads from a file directly.
|
Adding a note that exporting an empty FCstd file seems to fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24