From cb29df630954df46b2ee741f02f3416a09994f34 Mon Sep 17 00:00:00 2001 From: Karl Gordon Date: Mon, 29 Jul 2024 10:23:15 -0400 Subject: [PATCH] updates based on JOSS review and fixing broken link --- docs/index.rst | 4 +--- paper/paper.bib | 12 ++++++++++++ paper/paper.md | 16 ++++++++++------ 3 files changed, 23 insertions(+), 9 deletions(-) diff --git a/docs/index.rst b/docs/index.rst index f4b0d9f..ec57a11 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -164,12 +164,10 @@ contributors who will abide by the `Python Software Foundation Code of Conduct `Astropy`_. The following pages will help you get started with contributing fixes, code, or documentation (no git or GitHub experience necessary): -* `How to make a code contribution `_ +* `How to make a code contribution `_ * `Coding Guidelines `_ -* `Developer Documentation `_ - For the complete list of contributors please see the `dust_extinction contributors page on Github `_. diff --git a/paper/paper.bib b/paper/paper.bib index 0694541..48d27e5 100644 --- a/paper/paper.bib +++ b/paper/paper.bib @@ -17,6 +17,18 @@ @ARTICLE{Astropy22 adsnote = {Provided by the SAO/NASA Astrophysics Data System} } +@software{Barbary16, + author = {{Barbary}, Kyle}, + title = "{extinction v0.3.0}", + year = 2016, + month = dec, + eid = {10.5281/zenodo.804967}, + doi = {10.5281/zenodo.804967}, + publisher = {Zenodo}, + adsurl = {https://ui.adsabs.harvard.edu/abs/2016zndo....804967B}, + adsnote = {Provided by the SAO/NASA Astrophysics Data System} +} + @ARTICLE{Bastiaansen92, author = {{Bastiaansen}, P.~A.}, title = "{Narrow band multicolor photometry of reddened and unreddened early-type stars.}", diff --git a/paper/paper.md b/paper/paper.md index 1937db8..7af04af 100644 --- a/paper/paper.md +++ b/paper/paper.md @@ -36,19 +36,21 @@ in one place with a consistent interface. Many observation- and theory-based extinction curves have been presented in the literature. Having one python package providing these models ensures that they are straightforward to use and used within their valid wavelength -and parameter (where appropriate) ranges. +and parameter (where appropriate) ranges. Other packages provide extinction +curves, but they generally provide one or a small number of curves for +specialized purposes [e.g., @Barbary16]. The types of extinction models supported are Averages, Parameter Averages, Grain Models, and Shapes. The Averages are averages of a set of measured extinction -curves and examples are shown in Fig. \autoref{fig:averages}. The Parameter +curves and examples are shown in \autoref{fig:averages}. The Parameter Averages are extinction curve averages that depend on a parameter, often $R(V) = -A(V)/E(B-V)$ which is the ratio of total to selective extinction. Fig. +A(V)/E(B-V)$ which is the ratio of total to selective extinction. \autoref{fig:parameter_averages} shows examples of such models. The Grain -Models are those extinction curves computed using dust grain models. See Fig. +Models are those extinction curves computed using dust grain models. See \autoref{fig:grain} and note that these models provide dust extinction predictions from X-ray through submm wavelengths. The final type of models are Shapes that provide flexible functional forms that fit selected wavelength -ranges (see Fig. \autoref{fig:shapes} for an example). +ranges (see \autoref{fig:shapes} for an example). ![Examples of Average models based on observations in the Milky Way, Large Magellanic Cloud (LMC), and Small Magellanic Cloud (SMC) [@Bastiaansen92; @Gordon03; @Gordon09; @Gordon21; @Gordon24].\label{fig:averages}](average_models_uv_nir.png){ width=70% } @@ -68,7 +70,7 @@ a helper `extinguish` function that alternatively provides the fractional effects of extinction for a specific dust column (e.g., $A(V)$ value). This allows for the effects of dust to be modeled for or removed from an observation. -This package does not implement dust attenuation models. Dust attenuation +This package does not implement dust attenuation models[^1]. Dust attenuation results when observing more complex systems like a star with nearby, circumstellar dust or a galaxy with many stars extinguished by different amounts of dust. In both cases, the wavelength dependence of effects of dust are @@ -77,6 +79,8 @@ dust radiative transfer [@Steinacker13]. Specifically, these effects are the ave extinguished by differing amount of dust and the inclusion of a significant number of photons scattered into the observing beam. +[^1]: See [karllark/dust_attenuation](https://github.com/karllark/dust_attenuation). + Any published dust extinction model is welcome for inclusion in this package. # References