New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect aggregation calcs #753

Open

timlinux opened this issue Jan 10, 2025 · 0 comments

Assignees

Labels

bug

Contributor

timlinux commented Jan 10, 2025

So while testing Tunisia I found a few issues which cause systemic errors in the aggregation calcs:

The sum of weights was being divided by the number of layers which is incorrect
An error was being raised whenever a subarea dataset was missing - this is actually plausible to happen and should not be an error
The incorrect weighting keyword was being used for each level (indicator, factor, dimension) resulting in a default weighting of 1 always being used.

Resolving these issues should substantially improve and correct the outputs for all analysis results.

timlinux self-assigned this

timlinux added the bug label

timlinux added a commit that referenced this issue


          Fixes for #753 Incorrect aggregation calcs

bcd92db

timlinux mentioned this issue

WIP aggregation fixes #752

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment